Skip to content

added sensirion connector board#111

Open
hydronics2 wants to merge 5 commits into
tetrabiodistributed:mainfrom
hydronics2:master
Open

added sensirion connector board#111
hydronics2 wants to merge 5 commits into
tetrabiodistributed:mainfrom
hydronics2:master

Conversation

@hydronics2

Copy link
Copy Markdown
Member

eagle files and 3d renderings

eagle files and 3d renderings
i2c extender cut sheet
@Burhan-Q

Burhan-Q commented Aug 1, 2020

Copy link
Copy Markdown
Member

@hydronics2 A couple of thoughts/questions:
1 - I believe @capsulecorplab has enabled branch protection for the repo Master branch, so not sure if a direct merge will work, you may need to make a branch of the master repo to merge??
2 - Looking at the connector_board_w_parts.step vs the image of the pogo pins dimensions (specific model indicated by arrows I believe), it seems like the solid pins are significantly longer than the pogo pins; so are the solid pins just a placeholder? Just want to make sure I follow 100%.

Looking at a model @mechatroniks-git made, it looks like the pin dimensions are close to those on the spec sheet, so I may see if I can blend the two models, if you think they're good.

image

@hydronics2

Copy link
Copy Markdown
Member Author

@burhan, that's right it's just a placeholder. The dimension of the pogo pins is 5mm proud of the PCB (uncompressed).

@hydronics2

Copy link
Copy Markdown
Member Author

@Burhan-Q I can also try to dig up the exact pogo pins and re-export the step file if you all think it's necessary. Just let me know!

@Burhan-Q

Burhan-Q commented Aug 1, 2020

Copy link
Copy Markdown
Member

@Burhan-Q I can also try to dig up the exact pogo pins and re-export the step file if you all think it's necessary. Just let me know!

I'll check with @mechatroniks-git to see if he has the model of the pins readily available, but I should be good to go with what I have otherwise. Thanks for getting back to me

@hydronics2

Copy link
Copy Markdown
Member Author

@Burhan-Q Yea I can't readily find or make those exact pins so if @mechatroniks-git has the pogo pins and the connector (step files) that would be super helpful.

@Burhan-Q

Burhan-Q commented Aug 1, 2020

Copy link
Copy Markdown
Member

FYI using Part Number P-TET-000029-0 for this version of the PCB in Fusion and added to the Hardware Parts List

@Burhan-Q

Burhan-Q commented Aug 1, 2020

Copy link
Copy Markdown
Member

@hydronics2 looks like there's an issue with the pins for the phoenix-style connector. @mechatroniks-git mentioned that the mockup model has them placed in a safe location, could you update your model to have the same location for these pins?

image

@hydronics2

hydronics2 commented Aug 1, 2020

Copy link
Copy Markdown
Member Author

@Burhan-Q check it out.. I moved the phoenix connector outboard by 5mm.

https://github.com/hydronics2/project-tetra/tree/master/02_Development/FlowMeter/Sensirion_connector_board

I based the original off of @mechatroniks-git dwg file and it imported correctly into my CAD software so not sure what happened! but see if you can work with this model.

@capsulecorplab

Copy link
Copy Markdown
Member

@hydronics2 do you mind re-titling the pull request to use a closing keyword as specified in how to make design changes?

Also, for future pull requests, it's preferable to create a branch in the main repo as opposed to pulling from a forked repo.

@capsulecorplab

Copy link
Copy Markdown
Member

Responding to @Burhan-Q's question: Yes, branch protection is enabled for the master branch on the main repo, wherein pull requests should be made to after adding commits to a working branch in the main repo, but in this particular instance, the PR was created from the master branch on a forked repo.

on sensirion connector board... moved phoenic connector closer to pogo pins. current distance is 8.3mm or 0.33"
@Burhan-Q Burhan-Q added the Alpha_design_changes Design changes needs for Alpha prototype label Aug 26, 2020
@Burhan-Q

Copy link
Copy Markdown
Member

Is this PR ready to be merged or closed? This is part of an issue (#67), but it does not close said issue. @capsulecorplab if you're okay with how things stand, could you please review and merge?

@capsulecorplab capsulecorplab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to add the i2c_extender_p82b715.pdf datasheet?

@capsulecorplab

Copy link
Copy Markdown
Member

Looking at #67 I'm not quite sure what should constitute "closing" the issue, so @Burhan-Q I trust your judgement

@capsulecorplab

Copy link
Copy Markdown
Member

Also, please use a closing keyword in the PR title, if PR closes an issue

Base automatically changed from master to main March 9, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Alpha_design_changes Design changes needs for Alpha prototype

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants