Fix/reporter grep string#824
Merged
Merged
Conversation
Replace module-load argv hand-parsing with a commander preAction hook that reads the already-parsed --filter-list option and reuses parsePipeOptions() to extract the format. Avoids import-time side effects on process.env and removes a duplicate ad-hoc regex parser. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace the embedded "format=" pipe option with a proper commander --format flag on the run command. The CLI forwards it to the coverage pipe via client.pipeStore.outputFormat instead of parsing it out of the filter-list string. Usage: testomatio run "cmd" --filter-list "coverage:file=cov.yml" --format grep Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add a "Machine-readable output with --format" section to the Coverage pipe docs covering grep/json/newline/ids formats with piping examples, and list --filter-list / --format under the run command options in the CLI reference. Also shorten an overly long example comment in cli.js. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Move the formatFilterListIds() call out of the coverage pipe and into the run action, so any pipe that returns a test list goes through the same output path. --filter-list now always produces machine-readable stdout (default format "ids"), banner is suppressed whenever --filter-list or --format is set, and the duplicate "Grep string:" / dryRun plumbing is gone. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
When the user explicitly passes --format they are scripting, so the "Full Running Command" hint becomes stderr noise. Keep it only for interactive --filter-list use (no explicit format). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Cover all four formats (grep/json/newline/ids), verify that --format json produces valid, round-trippable JSON (including for ids with quotes/backslashes/newlines), and assert that every format preserves id count and order. Guards against silent format drift. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.