Skip to content

Fix #315 - RemoveIndexSignature deprecated in v4#320

Open
zymotik wants to merge 1 commit into
testing-library:mainfrom
zymotik:main
Open

Fix #315 - RemoveIndexSignature deprecated in v4#320
zymotik wants to merge 1 commit into
testing-library:mainfrom
zymotik:main

Conversation

@zymotik

@zymotik zymotik commented Sep 9, 2024

Copy link
Copy Markdown

RemoveIndexSignature added in type-fest v2.10.0. Renamed to OmitIndexSignature in v4.0.0. package.json updated to reflect compatibility.

@zymotik

zymotik commented Oct 2, 2024

Copy link
Copy Markdown
Author

#315

@G-Rath

G-Rath commented Oct 7, 2024

Copy link
Copy Markdown

This won't fix the issue as you're only changing devDependencies which is not used by downstream packages - instead you want to add type-fest as an optional peer dependency dependency to express the range of versions that are supported if the dependency is in the tree

@xiaoxiangmoe

xiaoxiangmoe commented Dec 21, 2024

Copy link
Copy Markdown

I think you should add type-fest to dependencies. Because if you add type-fest to peer dependency, it may conflict to other lib which using type-fest v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants