PR'ing that widen function I mentioned a while ago. :)#29
Conversation
tesk9
left a comment
There was a problem hiding this comment.
Heya, thanks for the PR!
The changes to checkContrast will make this a major version change, and generally I avoid those. I also generally avoid type aliases in function type annotations in packages because I think the compiler error messages are nicer without the alias.
I would love to see some tests against widen before merging as well.
|
Fair point... that said, I ended up going even deeper down the rabbit hole which fundamentally shifted my approach to this whole "widen"ing thing. Basing my theme-ing primitives on LCH means I can adjust the Lightness of any hue according to this 10-step system. Which means Ultimately I thought I could use elm-color-extra's Accessible module to do the lch conversion but it didn't have functions for converting True LCH back into the sRGB space which is why I had to adapt the css.land/lch functions. ALL THAT said, not sure whether to make a new elm package just for LCH or add it to elm-color-extra or adapt the functions to work with this repo... I'd love more eyes on the work and maybe some guidance / rubber 🦆'ing, I'm pretty much always available on Slack at @erlandsona if you're interested or want to talk more? Feel free to do whatever with this. |
No description provided.