fix cloaked names in the guidebook#236
Merged
KatTheFox merged 3 commits intoJul 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this isn't an ideal fix by any means, but it doesn't particularly matter if in 2.0 we are gonna nuke modnomicon anyway.
this makes it always recheck the hover name of an item for the spotlight page if there was no explicit title specified.
Does this by making an entirely new page type that overrides two methods in spotlight page to track whether a title was unspecified and to return the items hovername every time if it was indeed unspecified. This means that databank's mixins will work now since it correctly tracks the state of cloaking