fix(extra): per-value mkDefault and generate opt-out#98
Merged
Conversation
terlar
force-pushed
the
fix/auto-configure-hooks-generate
branch
from
d1e05af to
3e44a6d
Compare
autoConfigureHooks was wrapping the entire settings.pipelines attrset with lib.mkDefault. nixpkgs filterOverrides' discards all lower-priority definitions before per-key merging, so any user definition at default priority (100) silently dropped all profile pipeline paths from the mkDefault attrset (priority 1000). Fix by moving lib.mkDefault to each individual value so both the autoConfigureHooks and user definitions survive at the same attrset priority, letting attrsOf merge per-key with the user value winning. Also add gitlab-ci.generate and github-actions.generate boolean options (default true) and filter on them in autoConfigureHooks, allowing pipelines to opt out of file generation for backends they do not target.
terlar
force-pushed
the
fix/auto-configure-hooks-generate
branch
from
3e44a6d to
74a913d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.