- Updated shape inference functions (SetShapeFn) to explicitly validate array#1511
Open
copybara-service[bot] wants to merge 1 commit into
Open
- Updated shape inference functions (SetShapeFn) to explicitly validate array#1511copybara-service[bot] wants to merge 1 commit into
SetShapeFn) to explicitly validate array#1511copybara-service[bot] wants to merge 1 commit into
Conversation
76ea5f2 to
9caf06e
Compare
…idate array
lengths and return `absl::InvalidArgumentError` when input_splits size is 0.
- Added `OP_REQUIRES` bounds checking ahead of size evaluations in C++ kernel
`Compute` routines using modern `absl::InvalidArgumentError` status factories.
- Added comprehensive unit test coverage verifying safe exception throwing
across both Eager execution and Graph compilation paths.
PiperOrigin-RevId: 914477174
9caf06e to
32b5f8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetShapeFn) to explicitly validate arraylengths and return
absl::InvalidArgumentErrorwhen input_splits size is 0.OP_REQUIRESbounds checking ahead of size evaluations in C++ kernelComputeroutines using modernabsl::InvalidArgumentErrorstatus factories.across both Eager execution and Graph compilation paths.