Track latest tensor4all-rs (ae655a9), expand default sweeps, add the mac-m1-8gb profile - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pin moves from 7cfec22 to ae655a9, picking up the treetci early stop on max_bond_dim saturation (#575). Default sweeps grow: cases 2 and 3 run BENCH_RS=6,8,10,12,14, case 1 adds K=128. Probed on this machine, the dominant cost is case 2 naive at about 100 s per run at r = 12 and 14; the old quote of 12.6 s at r = 12 was stale. See docs/superpowers/specs/2026-08-07-latest-rev-expanded-sweep-design.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…verride Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A DHCP hostname in a public repository leaks the operator's institution and network location over time, and identifies nothing the profile name, the machine label and the chip and memory fields do not already carry. BENCH_MACHINE overrides the label, defaulting to the profile name. Hostnames already in git history are left as they are. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… pin result/mac-cpu stays frozen as the maintainer's machine's record at the previous pin. The expanded-sweep numbers for the current pin land in result/mac-m1-8gb (committed separately with the sweep). README case descriptions, cost notes and known issue 9 now quote the new pin's sweep and name the machine; AGENTS.md gains the one-profile-per-machine rule. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lingrui96
force-pushed
the
track-ae655a9-expanded-sweeps
branch
from
August 7, 2026 12:56
2ac74d5 to
266ff4c
Compare
Run post reboot on an otherwise idle machine, all gates green. run.yaml carries the machine label, chip and memory and no hostname; repo_rev is the clean docs commit that preceded the run. Known issue 9 now cites the measured pressure effect directly: the case-2 naive point at r = 10 cost about 28 s per run with swap nearly full and 16 s after a reboot, same code, same errors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Thanks for the thorough update. I checked the branch locally:
The benchmark and generated results look sound. I recommend merging after four small documentation/governance fixes; no rerun is needed:
My recommendations on the open questions:
With those small cleanups, this is ready to approve. |
…spec The Pushing section was written as a proposal awaiting veto, which is not what AGENTS.md is for: it holds active instructions. It comes out of this change and can return as accepted maintainer policy in its own change. The spec's status moves to implemented and its question list is replaced by the maintainer's answers, so it reads as a record rather than an open ask. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
shinaoka
added a commit
that referenced
this pull request
Aug 10, 2026
…, and the chi_out-driven case definitions Resolution policy: - Cargo.toml keeps the newer pin 1b9a517, which strictly contains the ae655a9 of PR #1 (verified as an ancestor), so it carries #574, #575 and #591. Cargo.lock regenerated against it. - Case definitions and knobs keep the chi_out-driven semantics of this branch: BENCH_CONTRACT_TOL, the ACI scale-relative tolerance, the degenerate-product guard, case 4 and the arm names. - The expanded default sweeps of PR #1 are adopted in full, BENCH_KS up to 128 and BENCH_RS = 6, 8, 10, 12, 14, because the whole mac-cpu sweep stays inside five minutes at these per-cell costs on this machine. - scripts/run_all.sh takes the hostname removal and the hardware fields of PR #1 and keeps the -dirty provenance logic of this branch. - result/mac-m1-8gb is kept exactly as committed in PR #1: it is another machine's record at the revision its own run.yaml states, and it is not regenerated here. - Known issues are unified and renumbered: the ACI item is now 9, the machine-bound naive timings of PR #1 are 10, and both sides' retirement of the ACI-pending item is kept once, as resolved at the current pin. - CI keeps the case-3 and case-4 smokes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
shinaoka
added a commit
that referenced
this pull request
Aug 10, 2026
… docs The sweep runs the expanded defaults adopted from PR #1 (BENCH_KS up to 128, BENCH_RS = 6, 8, 10, 12, 14) at the merged chi_out-driven case definitions, and finishes in 263 s including the reports. run.yaml stamps the merge commit 90fbd82 as repo_rev, with the hardware fields the merged run_all.sh now writes. What moved against the numbers quoted before the merge: - Case 2 naive is 16 to 17 s per run at R = 12 and 14, the two points the expanded default sweep adds, and the naive and fit error range now runs to 3.6e-9 with the zipup pair at 2.0e-5 to 1.1e-4. - Case 3 reaches 1.7e-8 at R = 12 and its zipup_treetn arm spans 2.3e-1 to 7.9e-1 over the wider sweep, still order one at every point. - Case 4 lands on chi_in of 78, 101, 117, 140, fitting to N^0.27 against the 0.28 of the previous sweep, so the sublinear conclusion is unchanged and the spread across reruns is now quoted. Its zipup_treetn arm passes 1 at N = 64, at 1.11, which widens the known issue 8 range to 2e-1 through 1.1. - Case 1 zipup at the new K = 128 point measures 3.9e-6 against a 1e-5 gate, noted in the README so a future extension of BENCH_KS is read as the gate reporting truncation growth rather than as a regression. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Review follow-ups
All four requested cleanups are in, no rerun needed:
Thank you for the answers on the open questions. Recorded in the spec, and the construction benchmark, option (a), is the direction for the next case.
🤖 Generated with Claude Code