Harden Windows cached clone pin checks in deps/build.jl - #122
Merged
Conversation
terasakisatoshi
enabled auto-merge
July 7, 2026 11:15
Normalize pinned commit and git rev-parse inputs to String, avoid wiping the cached tensor4all-rs checkout on non-git errors, and retry cargo builds once after cargo clean. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rev-parseinputs toStringso Julia 1.12stripdoes not pass aSubStringand accidentally invalidate the cacheddeps/.tensor4all-rscheckout.cargo buildonce aftercargo cleanwhen the first build fails.Context
Follow-up to #121. The latest
build.logfailure came from aMethodErroringit_rev_parsethat triggered an unnecessary cache wipe and a long rebuild.Test plan
julia --startup-file=no --project=. test/deps/build_config.jljulia --startup-file=no --project=. deps/build.jlon WindowsMade with Cursor