Skip to content

Improving silent errors on checking and submission #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ermolushka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improving silent errors on checking and submission #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tensara"
version = "0.3.0"
version = "1.1.3"
edition = "2021"
build = "build.rs"

Expand Down
47 changes: 47 additions & 0 deletions src/pretty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ pub fn pretty_print_checker_response(response: impl Read, parameters: &Parameter
| "TIME_LIMIT_EXCEEDED"
| "MEMORY_LIMIT_EXCEEDED"
| "RATE_LIMIT_EXCEEDED"
| "TOO_MANY_REQUESTS"
| "SANDBOX_TIMEOUT"
| "SANDBOX_OUTPUT_LIMIT"
| "OUTPUT_LIMIT_EXCEEDED"
Expand Down Expand Up @@ -717,6 +718,7 @@ pub fn pretty_print_benchmark_response_v2(response: impl Read, parameters: &Para
| "TIME_LIMIT_EXCEEDED"
| "MEMORY_LIMIT_EXCEEDED"
| "RATE_LIMIT_EXCEEDED"
| "TOO_MANY_REQUESTS"
| "SANDBOX_TIMEOUT"
| "SANDBOX_OUTPUT_LIMIT"
| "OUTPUT_LIMIT_EXCEEDED"
Expand Down Expand Up @@ -1274,6 +1276,7 @@ pub fn pretty_print_submit_response(response: impl Read) {
let mut total_benchmarks: u64 = 0;
let mut benchmark_results = vec![];
let mut completed = 0;
let mut finished = false;

for line in reader.lines().flatten() {
spinner.tick();
Expand Down Expand Up @@ -1392,6 +1395,7 @@ pub fn pretty_print_submit_response(response: impl Read) {
}

Some("ACCEPTED") => {
finished = true;
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
Expand Down Expand Up @@ -1454,6 +1458,7 @@ pub fn pretty_print_submit_response(response: impl Read) {
}

Some("WRONG_ANSWER") => {
finished = true;
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
Expand Down Expand Up @@ -1559,6 +1564,7 @@ pub fn pretty_print_submit_response(response: impl Read) {
}

Some("ERROR") => {
finished = true;
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
Expand All @@ -1575,6 +1581,7 @@ pub fn pretty_print_submit_response(response: impl Read) {
}

Some("COMPILE_ERROR") => {
finished = true;
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
Expand All @@ -1588,10 +1595,50 @@ pub fn pretty_print_submit_response(response: impl Read) {
break;
}

Some(
"RUNTIME_ERROR"
| "RATE_LIMIT_EXCEEDED"
| "TOO_MANY_REQUESTS"
| "TIME_LIMIT_EXCEEDED"
| "MEMORY_LIMIT_EXCEEDED"
| "SANDBOX_TIMEOUT"
| "SANDBOX_OUTPUT_LIMIT"
| "OUTPUT_LIMIT_EXCEEDED",
) => {
finished = true;
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
let event_type = current_event.as_deref().unwrap_or("ERROR");
if let Ok(data) = serde_json::from_str::<ErrorData>(json_data) {
let msg = data
.error
.or(data.message)
.unwrap_or_else(|| "Unknown error".to_string());
spinner.abandon_with_message(format!("{event_type}: {msg}"));
} else {
spinner.abandon_with_message(format!("{event_type}"));
}
break;
}

Some(_) => {}
None => {}
}
}

if !finished {
if let Some(pb) = progress_bar.take() {
pb.finish_and_clear();
}
spinner.finish_and_clear();
println!(
"{}",
style("No response received from server.")
.red()
.bold()
);
}
}

pub fn pretty_print_benchmark_response(mut response: impl Read) {
Expand Down