Migrate tests/purge_dlq_tasks_api_test.go#10339
Open
stephanos wants to merge 1 commit into
Open
Conversation
stephanos
changed the title
stephanos
force-pushed
the
stephanos/onebox-purge-dlq
branch
12 times, most recently
from
9e3ad7a to
5fe2c03
Compare
stephanos
commented
May 19, 2026
|
|
||
| FaultInjectionTarget struct { | ||
| Store DataStoreName | ||
| Method string |
Contributor
Author
There was a problem hiding this comment.
This could be extended later, but it's sufficient for now
stephanos
force-pushed
the
stephanos/onebox-purge-dlq
branch
7 times, most recently
from
fd2cec1 to
e862ccc
Compare
stephanos
force-pushed
the
stephanos/onebox-purge-dlq
branch
from
e862ccc to
58872dc
Compare
stephanos
commented
May 20, 2026
| }, | ||
| { | ||
| name: "DeleteTasksUnavailableError", | ||
| configure: func(p *purgeDLQTasksTestParams) { |
Contributor
Author
There was a problem hiding this comment.
Note that this test wasn't actually testing the error case ...
stephanos
commented
May 20, 2026
| Targets FaultInjectionTargets `yaml:"targets"` | ||
|
|
||
| // Injector optionally injects faults using runtime code instead of static YAML config. | ||
| Injector FaultInjector `yaml:"-" json:"-"` |
Contributor
Author
There was a problem hiding this comment.
This allows us to inject arbitrary persistence errors from functional tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Migrate
tests/purge_dlq_tasks_api_test.goto parallelsuite/testEnv; also also remove its use ofWithFxOptionsForServiceby allowing to inject custom errors into persistence calls.Why
We want to eliminate
WithFxOptionsForServiceas it is blocking us from migrating away from theonebox.goapproach (which duplicates the fx setup) since we don't want to expose an equivalent method intemporal/fx.go.