Remove WithFxOptionsForService from xdc tests#10322
Draft
stephanos wants to merge 1 commit into
Draft
Conversation
stephanos
force-pushed
the
stephanos/hooks-dc
branch
10 times, most recently
from
d0fed76 to
58f4566
Compare
stephanos
changed the title
stephanos
commented
May 19, 2026
| // scalable and flexible. The reason we need to do this on a per-service basis is that there are separate fx apps for | ||
| // each one. | ||
| // | ||
| // Deprecated: prefer dedicated TestClusterOption helpers or testhooks over injecting arbitrary Fx options. |
Contributor
Author
There was a problem hiding this comment.
Discourage adding more callers until we removed them all and can delete this method.
stephanos
force-pushed
the
stephanos/hooks-dc
branch
4 times, most recently
from
bbf001e to
618df7e
Compare
stephanos
changed the title
stephanos
force-pushed
the
stephanos/hooks-dc
branch
from
618df7e to
9538f80
Compare
stephanos
force-pushed
the
stephanos/hooks-dc
branch
2 times, most recently
from
cbfd59c to
174fd1c
Compare
stephanos
force-pushed
the
stephanos/hooks-dc
branch
from
174fd1c to
6e7049c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Migrated
xdcsuites to stop relying onWithFxOptionsForServiceto replace fx modules and instead use test hooks.Why
We want to eliminate
WithFxOptionsForServiceas it is blocking us from migrating away from theonebox.goapproach (which duplicates the fx setup) since we don't want to expose an equivalent method intemporal/fx.go.