feat: add transparent zstd compression for history_node data blobs#10318
Draft
mykaul wants to merge 1 commit into
Draft
feat: add transparent zstd compression for history_node data blobs#10318mykaul wants to merge 1 commit into
mykaul wants to merge 1 commit into
Conversation
Add optional zstd compression for large history_node table data blobs to reduce storage and network costs. Key design decisions: - Disabled by default (threshold=0) for safe rolling upgrades - Minimum compression floor of 1024 bytes (zstd framing overhead) - Skips compression if result is larger than original - Encoding marker "Proto3+zstd" stored in data_encoding column - Transparent decompression on read via NewDataBlob() - 16MB decoder memory limit to prevent memory bombs - TransactionSizeLimit uses compressed size; response Size uses logical size New dynamic config: system.historyNodeBlobCompressionThreshold Enable only after all nodes are upgraded to a version that can read compressed blobs. Fixes: temporalio#10307
mykaul
force-pushed
the
feature/history-node-compression
branch
from
3808a5d to
d0890a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional zstd compression for large history_node table data blobs to reduce storage and network costs.
Key design decisions:
Proto3+zstdstored indata_encodingcolumnNewDataBlob()TransactionSizeLimituses compressed size; responseSizeuses logical sizeNew dynamic config:
system.historyNodeBlobCompressionThresholdEnable only after all nodes are upgraded to a version that can read compressed blobs.
Fixes: #10307