worker deployment update-version-compute-config

[jaypipes]

Adds implementation of the UpdateWorkerDeploymentVersionComputeConfig gRPC API call with a temporal worker deployment update-version-compute-config CLI command. There is a --remove CLI flag that allows the user to explicitly delete the compute config from a Worker Deployment Version.

[jaypipes]

@chaptersix I don't believe the test failure has anything to do with this particular PR.

[chaptersix]

A couple things worth reconsidering here:

Command naming -- The CLI uses update-version-metadata for modifying properties on an existing version, and the gRPC API is UpdateWorkerDeploymentVersionComputeConfig. Using "replace" instead of "update" breaks the pattern -- we want CLI commands to be predictable so users can remember and guess at what a command or flag might be. Something like update-version-compute-config would be more consistent.

Implicit delete behavior -- Currently if --aws-lambda-function-arn is omitted, the command silently removes the compute config. That's surprising given no other command treats the absence of a flag as a destructive action. Something like a --remove flag (similar to how update-version-metadata uses --remove-entries) would make the behavior predictable and consistent with the rest of the CLI.

[jaypipes]

A couple things worth reconsidering here:

Command naming -- The CLI uses update-version-metadata for modifying properties on an existing version, and the gRPC API is UpdateWorkerDeploymentVersionComputeConfig. Using "replace" instead of "update" breaks the pattern -- we want CLI commands to be predictable so users can remember and guess at what a command or flag might be. Something like update-version-compute-config would be more consistent.

Implicit delete behavior -- Currently if --aws-lambda-function-arn is omitted, the command silently removes the compute config. That's surprising given no other command treats the absence of a flag as a destructive action. Something like a --remove flag (similar to how update-version-metadata uses --remove-entries) would make the behavior predictable and consistent with the rest of the CLI.

@chaptersix all great points. I will rework the patch!

[jaypipes]

@chaptersix sorry for the delay and thank you for your patience. I've updated the code per your review recommendations.