Skip to content

Nav feature refactor - #13

Open
FabianEP11 wants to merge 12 commits into
feature-wrapper-devfrom
nav-feature-refactor
Open

Nav feature refactor#13
FabianEP11 wants to merge 12 commits into
feature-wrapper-devfrom
nav-feature-refactor

Conversation

@FabianEP11

Copy link
Copy Markdown
Collaborator

No description provided.

@FabianEP11
FabianEP11 requested a review from RValner September 21, 2023 21:52
Comment thread CMakeLists.txt Outdated
Header header;
Position position;
Orientation orientation;
Pose pose;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between pose and data_pose, a small inline comment wouldn't do harm.

Comment thread include/temoto_robot_manager/robot.h Outdated
Comment thread include/temoto_robot_manager/robot_manager.h
Comment thread include/temoto_robot_manager/robot_manager.h Outdated
Comment thread src/robot.cpp Outdated
Comment thread src/robot.cpp Outdated
Comment thread src/robot_manager.cpp Outdated
Comment thread src/robot_manager.cpp Outdated
Comment thread src/robot_manager.cpp
@FabianEP11
FabianEP11 requested a review from RValner January 22, 2024 18:15
@RValner RValner self-assigned this Jan 23, 2024
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread src/robot_manager.cpp Outdated
@FabianEP11
FabianEP11 requested a review from RValner February 13, 2024 21:18

@RValner RValner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes needed.

Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot_manager_interface.h Outdated
Comment thread include/temoto_robot_manager/robot.h Outdated
Comment thread include/temoto_robot_manager/robot.h Outdated
@FabianEP11
FabianEP11 requested a review from RValner February 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants