Skip to content

chore(tekton): use hub resolver for git-clone stepaction#2758

Open
chmouel wants to merge 2 commits into
tektoncd:mainfrom
chmouel:use-hub-resolver-for-git-clone
Open

chore(tekton): use hub resolver for git-clone stepaction#2758
chmouel wants to merge 2 commits into
tektoncd:mainfrom
chmouel:use-hub-resolver-for-git-clone

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Jun 4, 2026

📝 Description of the Change

Replace the vendored git-clone StepAction (.tekton/stepactions/git-clone.yaml) with a reference to the upstream tektoncd catalog via the hub resolver. The local copy was a verbatim duplicate of catalog version 0.2 — no reason to carry it.

Also fixes error wrapping in DetectPacInstallation (%s + .Error()%w) to preserve the error chain for errors.Is/errors.As.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any issues. For an efficient workflow, I have considered installing pre-commit and running pre-commit install to automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Tekton pipeline configurations to use the hub resolver instead of the http resolver for the git-clone stepaction, referencing version 0.2 from the tektoncd catalog. It also removes a local git-clone stepaction definition file and improves error handling in bootstrap.go by wrapping the error with %w instead of formatting it as a string with %s. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chmouel chmouel marked this pull request as draft June 4, 2026 15:17
@chmouel chmouel marked this pull request as ready for review June 4, 2026 15:21
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.67%. Comparing base (bd262aa) to head (dbb1812).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2758   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files         210      210           
  Lines       21007    21007           
=======================================
  Hits        12536    12536           
  Misses       7685     7685           
  Partials      786      786           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chmouel chmouel force-pushed the use-hub-resolver-for-git-clone branch 2 times, most recently from 9985225 to 308be5a Compare June 4, 2026 17:47
chmouel and others added 2 commits June 4, 2026 19:48
Replace the vendored git-clone StepAction with a reference to the
upstream tektoncd catalog via the http resolver. The local copy was a
verbatim duplicate of catalog version 0.2.

Co-Authored-By: Claude <noreply@anthropic.com>
Preserves the error chain for errors.Is/errors.As callers.

Co-Authored-By: Claude <noreply@anthropic.com>
@chmouel chmouel force-pushed the use-hub-resolver-for-git-clone branch from 308be5a to f99e80e Compare June 4, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants