feat(tls): inject centrally managed TLS config into pruner webhook#3453
Open
infernus01 wants to merge 1 commit into
Open
feat(tls): inject centrally managed TLS config into pruner webhook#3453infernus01 wants to merge 1 commit into
infernus01 wants to merge 1 commit into
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
Member
Author
|
/hold |
tekton-robot
added
the
do-not-merge/hold
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
tekton-robot
removed
the
do-not-merge/hold
Member
|
/retest |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Wire the OpenShift APIServer TLS profile into the
tekton-pruner-webhookdeployment so that the pruner webhook applies the cluster-wide TLS version and cipher suite policy (PQC readiness).The pruner webhook uses the Knative webhook framework, which
WEBHOOK_TLS_MIN_VERSION,WEBHOOK_TLS_CIPHER_SUITES, andWEBHOOK_TLS_CURVE_PREFERENCESenvironment variables at startup viaknative.dev/pkg/network/tls.DefaultConfigFromEnv("WEBHOOK_").Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes