Skip to content

Add a directory option to check if a repo exists in current directory before attempting to clone - #9

Open
TylerFisher wants to merge 3 commits into
tegon:masterfrom
TylerFisher:master
Open

Add a directory option to check if a repo exists in current directory before attempting to clone#9
TylerFisher wants to merge 3 commits into
tegon:masterfrom
TylerFisher:master

Conversation

@TylerFisher

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.4%) to 79.562% when pulling 29fe7bd on TylerFisher:master into 7208474 on tegon:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.4%) to 79.562% when pulling 29fe7bd on TylerFisher:master into 7208474 on tegon:master.

Comment thread lib/github.js
this.token = options.token;
this.regexp = options.regexp;
this.gitaccess = options.gitaccess;
this.gitsettings = options.gitsettings;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. That was an accident, will fix.

Comment thread lib/github.js
return cli.debug('Repository ' + repo.name + ' ignored, exclude option: ' + this.exclude);
} else if (this.only && this.regexp && !repo.name.match(this.only)) {
cli.debug('Repository ' + repo.name + ' ignored, only option: ' + this.only);
return cli.debug('Repository ' + repo.name + ' ignored, only option: ' + this.only);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment thread lib/github.js
} else if (this.existingDirs && this.existingDirs.indexOf(repo.name) > -1) {
return cli.info('Repository ' + repo.name + ' ignored, directory already found');
}
else {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave this else in the previous line? Just a coding style preference 😄

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will fix.

@dalelotts

Copy link
Copy Markdown

@tegon I think this can be closed. It's been about 3 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants