API domain can be configured - #5
Closed
immer wants to merge 1 commit into
Closed
Conversation
So that this library can be used with GitHub Enterprise, Organization.prototype.BASE_URI will either read an environment variable (ENTERPRISE_DOMAIN), or fallback to GitHub's public domain.
Author
|
Just as a note, I don't consider this branch ready for master. I hope you can see where I'm going. Any feedback would be welcome when you have time. Cheers |
| var github = exports; | ||
|
|
||
| function Organization(options) { | ||
| this.BASE_URI = 'https://api.github.com/orgs/'; |
Owner
There was a problem hiding this comment.
I've never considered GitHub Enterprise, but it makes sense to support it somehow. Your solution is good, but I think we don't need a function for that. You could just change this line to:
this.BASE_URI = process.env.ENTERPRISE_DOMAIN || 'https://api.github.com/orgs/'What to you think?
Author
There was a problem hiding this comment.
Your solution is probably more simple. Although I have an aversion to any logic living in constructors. It's just a force of habit to make things more testable.
Having said that, I'll make the change and resubmit.
Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that this library can be used with GitHub Enterprise,
Organization.prototype.BASE_URI will either read an environment variable
(ENTERPRISE_DOMAIN), or fallback to GitHub's public domain.