Fix regex detection when a character class contains unescaped forward slash

[bubasuma]

Description

The current logic is failing to properly detect the following regular expression (see):

return string.replace( /([\\!"#$%&'()*+,./:;<=>?@\[\]^`{|}~])/g, "\\$1" );

resulting in

.....
return this.errors().filter(selector);},escapeCssMeta:function(string){if(string===undefined){return"";}
return string.replace(/([\\!"#$%&'()*+,./:;<=>?@\[\]^`{|}~])/g, "\\$1" );
            },

            idOrName: function( element ) {
                return this.groups[ element.name ] || ( this.checkable( element ) ? element.name : element.id || element.name );
            },

            validationTargetFor: function( element ) {

                // If radio/checkbox, validate first element in group instead
                if ( this.checkable( element ) ) {
                    element = this.findByName( element.name );
                }

                // Always apply ignore filter
                return $( element ).not( this.settings.ignore )[ 0 ];
            },

            checkable: function( element ) {
                return ( /radio|checkbox/i ).test( element.type );
            },
...

Root Cause

This is because the parser is stopping at the first unescaped forward slash which is located in the character class. However a character class can contain unescaped forward slash (see) and is a valid regular expression in Javascript.
Next it's parsing the rest of the regular expression as String starting from the string delimiter ` resulting in the next few lines not being minimized.

Solution

Added logic to ignore unescaped forward slash inside a character class

Issues

• Fixes jquery/jquery.validate.min.js file isn't getting minified properly. #110

Related Pull Requests

• To identify coorect end of the regex #124

Comment

I understand there had been an attempt to fix this issue but was reverted later due to regression issues caused by the fix. As I understand the regression issues were found in Magento according to this issue. I tested the solution with magento when JS minification is enabled and it worked fine.

 bin/magento config:set dev/js/minify_files 1
 bin/magento cache:flush
 bin/magento deploy:mode:set production

The same sequence of commands failed with the previously proposed solution.

[bubasuma]

Hi @tedivm

Could you please review this fix? I believe it resolves the issue. Thank you for maintaining this library!

[bubasuma]

Hi @tedivm,
Could you please take a look at this fix when you have a moment? Thank you!

[tedivm]

Thanks!

[bubasuma]

Thank You, @tedivm. I appreciate your prompt attention and support.