Implement immutable service revisions#140
Merged
Merged
Conversation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service_revisionssnapshots and bind rollouts and deployments to an exact revisionWhy
Deployment behavior was derived from mutable live service rows, so editing configuration could change the desired state of already-created deployments. Immutable revisions make the deployed specification explicit and auditable, while keeping rollout and agent reconciliation tied to the same source of truth.
Impact
This is a full switch with no backwards-compatible mixed-agent mode. The release requires the documented maintenance-window cutover and upgraded agents advertising the
service_revision_v1capability. Existing containers are recreated one at a time; images are pulled before removal, but each container has an inherent stop-to-start gap because its static IP is reused.Validation
pnpm vitest run— 118 tests passedpnpm exec tsc --noEmitpnpm buildgo test ./...git diff --check