Skip to content

Fix service metrics mobile layout #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjunkomath merged 1 commit into from
Jul 10, 2026
Merged

Fix service metrics mobile layout #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions web/components/service/details/service-details-overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
YAxis,
} from "recharts";
import useSWR from "swr";
import { LocalDate } from "@/components/core/local-date";
import { useService } from "@/components/service/service-layout-client";
import { Badge } from "@/components/ui/badge";
import { Card } from "@/components/ui/card";
Expand Down Expand Up @@ -237,17 +236,17 @@ function ServiceMetricsPanel({
);
return (
<div className="flex h-full min-h-72 flex-col gap-4 p-4">
<div className="flex items-start justify-between gap-3">
<div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
<div className="min-w-0">
{isLoading ? (
<div className="flex flex-wrap items-end gap-x-5 gap-y-2">
<div className="flex flex-nowrap items-end gap-x-5">
<Skeleton className="h-7 w-24" />
<Skeleton className="h-7 w-20" />
</div>
) : (
<div className="flex flex-wrap items-end gap-x-5 gap-y-2">
<div className="flex flex-nowrap items-end gap-x-5">
{summaryItems.map((item) => (
<div key={item.label}>
<div key={item.label} className="shrink-0">
<p className="font-mono text-xl font-semibold tabular-nums tracking-tight">
{item.value}
</p>
Expand All @@ -257,18 +256,11 @@ function ServiceMetricsPanel({
</div>
)}
</div>
<div className="flex flex-col items-end gap-2">
{stats ? (
<p className="text-sm text-muted-foreground">
<LocalDate value={stats.windowEnd} format="compactDate" />
</p>
) : null}
<ServiceChartModeToggle
value={chartMode}
onChange={setChartMode}
disabled={isLoading || isUnavailable}
/>
</div>
<ServiceChartModeToggle
value={chartMode}
onChange={setChartMode}
disabled={isLoading || isUnavailable}
/>
</div>

<div className="min-h-40 min-w-0 flex-1">
Expand Down Expand Up @@ -386,7 +378,7 @@ function ServiceChartModeToggle({
];

return (
<div className="inline-flex rounded-md border border-border bg-muted/30 p-0.5">
<div className="flex w-full rounded-md border border-border bg-muted/30 p-0.5 sm:w-auto">
{options.map((option) => {
const isSelected = value === option.value;

Expand All @@ -398,7 +390,7 @@ function ServiceChartModeToggle({
disabled={disabled}
onClick={() => onChange(option.value)}
className={cn(
"rounded-[5px] px-2 py-0.5 text-xs font-medium transition-colors",
"flex-1 rounded-[5px] px-2 py-0.5 text-xs font-medium transition-colors sm:flex-none",
isSelected
? "bg-background text-foreground shadow-sm"
: "text-muted-foreground hover:text-foreground",
Expand Down
Loading