[codex] Clean up service details overview UI#106
Merged
Conversation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
techulus-agent
commented
Jul 7, 2026
techulus-agent
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review — Clean up service details overview UI
Reviewed the diff against main. This is a focused, low-risk UI cleanup and it holds together well.
Verified
- All eight removed helpers (
getLockedServerLabel,formatReplicaCompact,formatPlacementLabel,formatEndpointCount,formatDataSummary,formatBackupLabel,formatDeployScheduleLabel,lowercaseFirstLetter) and the now-unused imports (cronstrue,Cpu,HardDrive) have zero remaining references in the file — no orphaned calls or dead imports left behind. - Helpers that were shared with the removed sections (
formatInstanceSummary,getConfiguredReplicaCount,formatResources,formatPortSummary,formatCount) are all still defined and still used. - Moving resource limits into the Instances section and dropping the Capacity / Data & ops cards is coherent; the request-graph default flipping to Total matches the reordered toggle (
Totalfirst, thenRPS). - The
border-border/ring-0class additions are purely cosmetic.
Result: No correctness or dead-code issues. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm exec biome check components/service/details/service-details-overview.tsxpnpm exec tsc --noEmit