Skip to content

Harden formatDate validation to prevent RangeError on invalid inputs #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techbuzzz merged 4 commits into from
Jan 28, 2026
Merged

Harden formatDate validation to prevent RangeError on invalid inputs #36

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b9438b
Initial plan
Copilot Jan 28, 2026
a7cc5d8
Add validation for formatDate to prevent RangeError with invalid dates
Copilot Jan 28, 2026
1db017e
Improve date validation: add rollover check and error handling
Copilot Jan 28, 2026
1e530f9
Refactor formatDate: extract fallback parsing to eliminate duplication
Copilot Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 35 additions & 7 deletions web/src/views/Standups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,21 +336,49 @@ export default {
// Treat as date-only value to avoid timezone shifts
if (!dateString) return ''

// Helper function for fallback parsing
const fallbackParse = () => {
try {
const date = new Date(dateString)
if (isNaN(date.getTime())) return 'Invalid date'
return date.toLocaleDateString('en-US', {
weekday: 'long',
year: 'numeric',
month: 'long',
day: 'numeric'
})
Comment on lines +344 to +349

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date formatting options object is duplicated in both fallbackParse() and the main return path. This increases the chance of the two outputs diverging over time. Consider extracting the toLocaleDateString options into a single constant (e.g., const dateFormatOptions = { ... }) and reusing it in both places.

Copilot uses AI. Check for mistakes.
} catch (e) {
return 'Invalid date'
}
}

const dateOnly = dateString.includes('T') ? dateString.split('T')[0] : dateString
const parts = dateOnly.split('-')

if (parts.length !== 3) {
// Fallback to standard parsing if format is unexpected
return new Date(dateString).toLocaleDateString('en-US', {
weekday: 'long',
year: 'numeric',
month: 'long',
day: 'numeric'
})
return fallbackParse()
}

const [year, month, day] = parts.map(Number)
const date = new Date(year, month - 1, day) // Use local timezone with specific date parts

// Validate that year, month, and day are finite numbers within expected ranges
if (!Number.isFinite(year) || !Number.isFinite(month) || !Number.isFinite(day) ||
year < 1000 || year > 9999 || month < 1 || month > 12 || day < 1 || day > 31) {
// Values are invalid, return error message
return 'Invalid date'
}

// Construct date and validate it matches the input values
const date = new Date(year, month - 1, day)
if (isNaN(date.getTime()) ||
date.getFullYear() !== year ||
date.getMonth() !== month - 1 ||
date.getDate() !== day) {
// Date rolled over (e.g., Feb 31 -> Mar 3), so it's invalid
return 'Invalid date'
}

return date.toLocaleDateString('en-US', {
weekday: 'long',
year: 'numeric',
Expand Down