Skip to content

[FEAT] #221 FCM 서비스 호출 기반 알림 구현 - #223

Open
PBEM22 wants to merge 2 commits into
developfrom
feat/#221/fcm-notification
Open

[FEAT] #221 FCM 서비스 호출 기반 알림 구현#223
PBEM22 wants to merge 2 commits into
developfrom
feat/#221/fcm-notification

Conversation

@PBEM22

@PBEM22 PBEM22 commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

📌 관련 이슈

✨ 변경 사항

  • FcmNotificationService 신규 생성 — 새 참여자 알림, 입금 확인 요청 알림, 분철글 상태 변경 알림, 배송 완료(후기 유도) 알림 4종
  • OrderCreateService — 주문 생성 후 모집자에게 새 참여자 알림, 모집 완료(CLOSED) 시 참여자 전원에게 상태 변경 알림
  • PaymentService — 입금 폼 제출 후 모집자에게 입금 확인 요청 알림, 입금 확인(PAID) 처리 후 전원 PAYMENT_DONE 알림
  • OrderService — 배송 시작 등록 후 전원 SHIPPING 알림
  • ParticipationService — 배송 완료 확인 후 해당 참여자에게 후기 유도 알림, 전체 배송 완료(DELIVERED) 시 전원 알림

📸 테스트 증명 (필수)

📚 리뷰어 참고 사항

  • @Profile("!test")로 테스트 환경에서 FcmNotificationService 빈을 생성하지 않음
  • @Autowired(required = false)로 optional 주입 → null 체크로 FCM 발송 실패가 트랜잭션을 롤백하지 않음
  • deeplink 값은 iOS/Android 팀 확정 전까지 빈 문자열 + TODO 주석 처리

✅ 체크리스트

  • 브랜치 전략(git flow)을 따랐나요? (develop -> feat/...)
  • 로컬에서 빌드 및 실행이 정상적으로 되나요?
  • 불필요한 주석(TODO 등)이나 더미 코드는 제거했나요?
  • 컨벤션(커밋 메시지, 코드 스타일)을 지켰나요?

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PBEM22, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b488c05b-0578-4659-b367-abab803ca6da

📥 Commits

Reviewing files that changed from the base of the PR and between 1c790e4 and 311fd5a.

📒 Files selected for processing (6)
  • src/main/java/org/sopt/poti/domain/fcmtoken/repository/FcmTokenRepository.java
  • src/main/java/org/sopt/poti/domain/fcmtoken/service/FcmNotificationService.java
  • src/main/java/org/sopt/poti/domain/order/service/OrderCreateService.java
  • src/main/java/org/sopt/poti/domain/order/service/OrderService.java
  • src/main/java/org/sopt/poti/domain/participation/service/ParticipationService.java
  • src/main/java/org/sopt/poti/domain/payment/service/PaymentService.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#221/fcm-notification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PBEM22 PBEM22 self-assigned this Jul 28, 2026
- FcmNotificationService 생성 (새 참여자/입금확인/상태변경/배송완료 알림)
- OrderCreateService, PaymentService, OrderService, ParticipationService에 알림 호출 추가
- @Profile("!test") + @Autowired(required = false)로 테스트 환경 격리
@PBEM22
PBEM22 force-pushed the feat/#221/fcm-notification branch from fba4273 to 13bc2db Compare July 28, 2026 06:14
@PBEM22
PBEM22 requested a review from 88guri July 28, 2026 06:52
@PBEM22 PBEM22 added ✨ Feat 새로운 기능 추가 🐴 채륜 막시무스 labels Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feat 새로운 기능 추가 🐴 채륜 막시무스

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] FCM 서비스 호출 기반 알림 구현

1 participant