[FIX] #218 Swagger 서버 URL 환경별 분리 - #219
Conversation
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSwagger의 운영 서버 URL과 설명을 하드코딩하지 않고 환경변수 기반 설정으로 주입합니다. 주입된 서버를 기존 로컬 서버와 함께 OpenAPI 문서의 서버 목록에 등록합니다. ChangesSwagger 서버 설정 외부화
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/org/sopt/poti/global/config/SwaggerConfig.java`:
- Line 47: Update the server list construction in SwaggerConfig so localServer
is added only when its URL differs from currentServer; when the application.yml
default URL is used, retain a single server entry while preserving both entries
for distinct URLs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d7d57034-de37-4270-8d6e-49541b165508
📒 Files selected for processing (2)
src/main/java/org/sopt/poti/global/config/SwaggerConfig.javasrc/main/resources/application.yml
- serverUrl이 localhost일 때 localServer를 추가하지 않도록 수정 - application.yml 충돌 해소: swagger + firebase + gemini 설정 모두 유지
88guri
left a comment
There was a problem hiding this comment.
Swagger 서버 URL 하드코딩 문제 깔끔하게 해결해주셨네요 ~
현재 서버가 드롭다운 첫 번째로 오도록 순서 바꾸신 것도 잘 봤습니다 😸
문제
SwaggerConfig에 서버 URL이
poti.kr로 하드코딩되어 있어 dev 환경에서 Swagger 요청이 prod로 날아가는 문제해결
SWAGGER_SERVER_URL,SWAGGER_SERVER_DESC환경변수로 서버 URL 관리http://localhost:8080(로컬 fallback)환경별 .env 설정
dev
prod
Closes #218
Summary by CodeRabbit