[Refactor/#157] 개발/운영 서버 분리 - #158
Conversation
📝 WalkthroughWalkthrough개발·운영 서버 URL을 product flavor별로 주입하도록 Gradle 설정을 변경하고, CI의 Changes서버 및 UI 설정 변경
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Ktlint check passed. Run: https://github.com/team-poti/POTI-ANDROID/actions/runs/29750231505 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/build.gradle.kts`:
- Around line 18-24: Update requiredLocalProperty so it explicitly loads values
from the project’s local.properties file instead of relying only on
properties[key]. Preserve the required-key validation while ensuring
local.properties values are available during configuration, and provide a safe
flavor-specific default or fallback where missing keys would otherwise fail
productFlavors evaluation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e5e5b1d0-a410-4537-8fcb-044614b40e4e
📒 Files selected for processing (6)
.github/workflows/pr-checker.ymlapp/build.gradle.ktsapp/src/main/java/com/poti/android/presentation/history/list/HistoryListScreen.ktapp/src/main/java/com/poti/android/presentation/party/create/PartyArtistSelectScreen.ktapp/src/main/java/com/poti/android/presentation/party/detail/component/PartyDetailContent.ktgradle/libs.versions.toml
| fun requiredLocalProperty(key: String): String = | ||
| requireNotNull(properties[key] as? String) { | ||
| "$key is required in local.properties" | ||
| } | ||
|
|
||
| fun buildConfigString(value: String): String = "\"$value\"" | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# local.properties 값을 Gradle properties로 강제 주입하는 로직이 존재하는지 확인합니다.
rg -i 'local\.properties' -g '*.gradle*' -g '*.kts'Repository: team-poti/POTI-ANDROID
Length of output: 160
local.properties를 직접 읽도록 구성해 주세요
현재 properties[key]만 쓰고 있어서, local.properties 값은 자동으로 들어오지 않습니다. 또한 productFlavors는 구성 단계에서 모두 평가되므로, 한 키라도 없으면 빌드가 바로 실패할 수 있습니다.
local.properties를 명시적으로 로드하거나, flavor별 기본값/대체값을 두는 쪽이 더 안전합니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/build.gradle.kts` around lines 18 - 24, Update requiredLocalProperty so
it explicitly loads values from the project’s local.properties file instead of
relying only on properties[key]. Preserve the required-key validation while
ensuring local.properties values are available during configuration, and provide
a safe flavor-specific default or fallback where missing keys would otherwise
fail productFlavors evaluation.
cmj7271
left a comment
cmj7271
left a comment
There was a problem hiding this comment.
PR 내용은 아니지만.... 수정사항일거 같아서 남겼습니닷
수고하셨습니다~
| topBar = { | ||
| PotiHeaderPage( | ||
| onNavigationClick = onBackClick, | ||
| title = stringResource(uiState.titleRes), | ||
| onTrailingIconClick = onSwitchModeClick, |
There was a problem hiding this comment.
p1: PotiHeaderPage 에 modifier = Modifier.statusBarsPadding() 추가해야할 것 같습니다.
WindowInsets() 랑 WindowInsets(0.dp) 차이 찾으려고 Preview 를 확인했는데, 상태바 패딩이 안된 상태였던거 같습니다.
There was a problem hiding this comment.
앱 실행 시에는 MainScreen의 최상위 Scaffold에서 받은 innerPadding을 각 NavGraph 화면 modifier로 전달하고 있어서, PotiHeaderPage 바깥 레이어에서 이미 status bar inset이 적용되고 있습니다.
앱 실행시켜 보면 상단 상태바만큼 제대로 패딩 적용되고 있습니다.
WindowInsets()를 WindowInsets(0.dp)로 바꾼 이유는 composeBom 버전을 올리면서 인자가 하나 더 추가되어 모호성을 줄이고자 추가했습니다. 기본 composeBom 버전이 mateiral3랑 안 맞아 release 버전에서 빌드 컴파일이 깨질 가능성이 있어서 수정했습니다.
| topBar = { | ||
| PotiHeaderPage( | ||
| onNavigationClick = onPopBackStack, | ||
| title = stringResource(R.string.create_header_artist_search), | ||
| ) | ||
| }, |
There was a problem hiding this comment.
| import com.poti.android.data.mock.UiMockData | ||
| import com.poti.android.domain.model.party.PartyDetail | ||
|
|
||
| @OptIn(ExperimentalLayoutApi::class) |
There was a problem hiding this comment.
p3: UI 변경사항이 없어보이는데 추가된 이유가 있을까여?
진짜 몰라서 질문입니다
There was a problem hiding this comment.
UI 변경 목적이라기보다는 FlowRow를 사용하고 있는데, 해당 API가 ExperimentalLayoutApi라 컴파일 경고를 명시적으로 처리하려고 추가했습니다.
3 participants
Related issue 🛠️
Work Description ✏️
Screenshot 📸
N/A
Uncompleted Tasks 😅
N/A
To Reviewers 📢
local.properties에poti.dev.base.url,poti.prod.base.url값 반영 필요합니다.노션의 환경변수 페이지에
local.properties값 적어놔서 그대로 복붙해서 사용하시면 될 것 같아욤Summary by CodeRabbit
버그 수정
개선 사항