π« feat: CI/CD μ€ν μκ° μ΅μ ν λ° μν¬νλ‘μ° κ΅¬μ‘° κ°μ #7
Merged
Merged
Conversation
π WalkthroughWalkthroughThe workflows now run tests separately from packaging, restrict CI to pull requests, and check ECR for existing SHA-tagged images before conditionally building and pushing development or production Docker images. ChangesCI/CD workflow optimization
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant AmazonECR
participant Docker
GitHubActions->>AmazonECR: Check dev or prod SHA image tag
AmazonECR-->>GitHubActions: Return image existence
GitHubActions->>Docker: Build image when tag is absent
Docker-->>GitHubActions: Provide built image
GitHubActions->>AmazonECR: Push image when tag is absent
Possibly related issues
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-dev.yml:
- Around line 54-66: Update the image-check steps in
.github/workflows/deploy-dev.yml lines 54-66 and
.github/workflows/deploy-prod.yml lines 54-66 so aws ecr describe-images
distinguishes a not-found response from other failures: set exists=false only
when the image is absent, and fail the step for authentication, throttling,
network, or other AWS errors while preserving exists=true for found images.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 17eb03a7-5748-4563-9c1e-ed74ca9d7e87
π Files selected for processing (3)
.github/workflows/ci.yml.github/workflows/deploy-dev.yml.github/workflows/deploy-prod.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#οΈβ£ Issue Number
π μμ½(Summary)
pull_requestμμλ§ CIκ° μ€νλλλ‘ λ³κ²½νμ΅λλ€../gradlew testλ§ μννλλ‘ μ 리νκ³ ,bootJarλ° Docker build λ¨κ³λ₯Ό μ κ±°ν΄ λΉ λ₯Έ νΌλλ°±μ μ§μ€νλλ‘ κ΅¬μ±νμ΅λλ€.bootJarλ¨κ³λ₯Ό μ κ±°νκ³ , Docker buildκ° μ€μ μ°μΆλ¬Ό κ²μ¦ μν μ λ΄λΉνλλ‘ μ€λ³΅ λΉλ ꡬ쑰λ₯Ό μ 리νμ΅λλ€.π 리뷰 μμ²μ¬ν
π» ν μ€νΈ κ²°κ³Ό
β±οΈ μ€ν μκ° λΉκ΅
bootJarλ° Docker build λ¨κ³λ₯Ό μ κ±°νκ³testλ§ μννλλ‘ μ‘°μ νλ©΄μ μ€ν μκ°μ΄ 2λΆ 57μ΄μμ 46μ΄λ‘ κ°μν΄, μ½ 74% λ¨μΆ ν¨κ³Όλ₯Ό νμΈνμ΅λλ€.π ν¬μΈνΈ
bootJarμ€λ³΅ μνμ μ€μ¬ νΌλλ°± 루νμ λ°°ν¬ μκ°μ ν¨κ» κ°μ νλ λ°©ν₯μΌλ‘ μ 리νμ΅λλ€.βοΈ νκ³
Summary by CodeRabbit