Add legacy glibc-compatible Linux build path#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
glibc 2.34.GLIBC_2.17by building on a CentOS7/manylinux2014 toolchain.Description
docker/Dockerfile.core.legacybased onquay.io/pypa/manylinux2014_x86_64and devtoolset-10 to target aglibc 2.17compatibility baseline and install required build tooling and Python packages.dccc-core-legacyservice indocker-compose.core.ymlwith separate Conan/CMake volumes andCONAN_CPPSTD=gnu17to run legacy builds without mixing caches with the default container..github/workflows/cross-compile.ymlto build and run the legacy Docker image for Linux jobs and add a post-build GLIBC symbol-version verification step that fails the job if any packaged ELF references symbols newer thanGLIBC_2.17.localizer/src/README.mdto document how to build using the legacy container and explain the compatibility intent and separate volumes.Testing
bash -n scripts/docker-build-core.shto validate the build script syntax and it succeeded.ruby -e 'require "yaml"; YAML.load_file(".github/workflows/cross-compile.yml"); YAML.load_file("docker-compose.core.yml")'and it succeeded.Dockerfilecontains expected markers with a smallpython3check formanylinux2014_x86_64,devtoolset-10, andCONAN_HOMEand it succeeded.dockeris not installed in the current environment, so full image builds and end-to-end CI validation will run in CI where Docker is available.Codex Task