Skip to content

The first notebook#11

Open
tcjansen wants to merge 26 commits into
masterfrom
the-first-notebook
Open

The first notebook#11
tcjansen wants to merge 26 commits into
masterfrom
the-first-notebook

Conversation

@tcjansen

@tcjansen tcjansen commented Jun 5, 2019

Copy link
Copy Markdown
Owner

A place for reviewing work on this tutorial.

Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb
Comment thread observing_examples.ipynb Outdated
@bmorris3

Copy link
Copy Markdown

With the latest updates (dfc48f2) it's looking good!

RE pwv_kpno: I think we should get @eteq's opinion before we remove pwv_kpno, but I think you've proven that significant scattering/absorption in the blue is an important factor to include for realistic counts in the optical.

RE #2: I think you can close this issue now, it is as completely addressed as it can be.

RE #3: perhaps this is next on your todo list?

@tcjansen

Copy link
Copy Markdown
Owner Author

RE #3: perhaps this is next on your todo list?

I've been working on decoding skycalc_cli for replacing pvw_kpno, but since we're going to wait for @eteq's input on that I will get started on including Kepler instead 👍

@bmorris3

Copy link
Copy Markdown

Great, and now #1 can be next in your queue thanks to the wonderful folks at SVO!

Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated

@pllim pllim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. GitHub suggestion wasn't matching the LOC properly, so I can't use it to the fullest here.

Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb
Comment thread observing_examples.ipynb Outdated
tcjansen and others added 7 commits June 13, 2019 14:58
Co-Authored-By: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-Authored-By: P. L. Lim <2090236+pllim@users.noreply.github.com>
… out binset and forced tapering in Observation calls
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb
Comment thread observing_examples.ipynb Outdated
Comment thread observing_examples.ipynb Outdated
Comment thread atmospheric_transmittance.py Outdated
@bmorris3

Copy link
Copy Markdown

Progress in the last two commits looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants