Remove 2 'early' tests re MV of HexDigits#32
Open
jmdyck wants to merge 1 commit into
Open
Conversation
Each of these tests is expected to raise a syntax error
because it has a string literal with a UnicodeEscapeSequence
that specifies an out-of-range code point.
Originally, this restriction was expressed as an early error:
It is a Syntax Error if the MV of |HexDigits| > 0x10FFFF.
But PR tc39/ecma262#773 replaced it with an in-grammar restriction:
CodePoint :: HexDigits [> but not if MV of HexDigits > 0x10FFFF ]
So you might expect this PR to move the tests from 'early' to 'fail',
but strangely, they already exist in 'fail'. In fact, these 2 tests
have existed in both 'early' and 'fail' since the start of the repo.
Until the merge of 773, only the 'early' copies were correct;
after, only the 'fail' copies are correct.
This PR removes the incorrect 'early' copies.
Resolves issue tc39#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of these tests is expected to raise a syntax error because it has a string literal with a UnicodeEscapeSequence that specifies an out-of-range code point.
Originally, this restriction was expressed as an early error:
It is a Syntax Error if the MV of |HexDigits| > 0x10FFFF.But PR tc39/ecma262#773 replaced it with an in-grammar restriction:
CodePoint :: HexDigits [> but not if MV of HexDigits > 0x10FFFF ]So you might expect this PR to move the tests from 'early' to 'fail', but strangely, they already exist in 'fail'. In fact, these 2 tests
have existed in both 'early' and 'fail' since the start of the repo. Until the merge of 773, only the 'early' copies were correct;
after, only the 'fail' copies are correct. This PR removes the incorrect 'early' copies.
Resolves issue #15