libgit2: fix broken build#68
Open
tc-agent wants to merge 2 commits into
Open
Conversation
Fuzzing Coverage ReportTested: project
Per-harness
Δ = (after − before) / before, to accommodate that denominators may change. "new" when before is 0; "deleted" when after is 0. |
tc-agent
force-pushed
the
master
branch
2 times, most recently
from
May 27, 2026 16:16
b5fd10c to
712a52f
Compare
tc-agent
force-pushed
the
libgit2-fix-broken-build
branch
from
May 27, 2026 20:14
f4230c6 to
9573093
Compare
tc-agent
force-pushed
the
master
branch
6 times, most recently
from
May 28, 2026 18:05
af7f9a7 to
806b281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSS-Fuzz build for libgit2 has been failing since 2026-05-08 (see the
build status index
for
last_successful_build.finish_time). The Fuzz Introspector profilereflects this — no recent fuzzer or coverage build is available
(profile).
The last successful coverage build (2026-05-08) reports 21.86% line coverage
(report).
Two latent problems in
build.sh's hand-rolled compile invocation neededaddressing:
-I./include/git2was on the compiler include path. libgit2 ships aVisual Studio compatibility shim at
include/git2/stdint.h(a no-op outside
_MSC_VER); with that directory on the include paththe system
<inttypes.h>resolves its#include <stdint.h>to theshim instead of clang's, leaving
uintmax_t/uint64_t/uint32_tundefined and failing the fuzzer-side compile with "unknown type name
'uintmax_t'". Removing the flag restores the system header search.
libgit2's CMake configures
git2_features.h(andexperimental.h) into\${PROJECT_BINARY_DIR}/gen_headers/— seesrc/util/CMakeLists.txtand
src/libgit2/CMakeLists.txt;the in-tree libgit2 build references them via
LIBGIT2_INCLUDES, butbuild.shdid not have that directory on its own include path. Adding-I./gen_headersmakes the configured headers visible to the fuzzercompile step.
After the fix, fuzzer compilation completes cleanly, all eight existing
fuzz targets build, and the coverage build returns to the pre-break level
documented in the 2026-05-08 report linked above (21.86% lines).