lwan: fix broken build#50
Open
tc-agent wants to merge 2 commits into
Open
Conversation
Fuzzing Coverage ReportTested: project
Per-harness
Δ = (after − before) / before, to accommodate that denominators may change. "new" when before is 0; "deleted" when after is 0. |
tc-agent
force-pushed
the
master
branch
10 times, most recently
from
May 9, 2026 08:46
5610e75 to
6c52918
Compare
tc-agent
force-pushed
the
lwan-fix-broken-build
branch
from
May 9, 2026 17:27
00297ba to
ae6c8bb
Compare
tc-agent
force-pushed
the
master
branch
11 times, most recently
from
May 11, 2026 08:23
7114cc5 to
43143eb
Compare
tc-agent
force-pushed
the
master
branch
17 times, most recently
from
May 21, 2026 05:13
5573df7 to
9a36aa8
Compare
tc-agent
force-pushed
the
master
branch
4 times, most recently
from
May 27, 2026 06:33
6125235 to
e512e7e
Compare
tc-agent
force-pushed
the
lwan-fix-broken-build
branch
from
May 27, 2026 06:43
ae6c8bb to
ddd467a
Compare
tc-agent
force-pushed
the
master
branch
5 times, most recently
from
May 27, 2026 16:16
b5fd10c to
712a52f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fuzzer build last succeeded on 2026-04-23 (build status dashboard, Fuzz Introspector). Daily builds since have all failed at the compile step in
src/lib/lwan-straitjacket.c:Lwan landed Landlock support in 3cb40844 on the same date. The base-builder image (
base-builder:ubuntu-24-04) ships kernel 6.8 headers, which lack symbols introduced in Linux 6.10 (LANDLOCK_ACCESS_FS_IOCTL_DEV) and 6.12 (LANDLOCK_SCOPE_ABSTRACT_UNIX_SOCKET,LANDLOCK_SCOPE_SIGNAL,scopedstruct member).lwan-straitjacket.cuses these unconditionally underLWAN_HAVE_LANDLOCK.The coverage build also currently fails at the same compile step with the same errors. Its
last_successful_build(2025-04-22) is older than the public log retention window, so this fix addresses the currently visible failure but cannot verify whether a separate prior issue exists.What
Patch CMake at build time to remove the
find_path(LANDLOCK_HEADER ...)block, which keepsLWAN_HAVE_LANDLOCKundefined and skips the offending code. The fuzz harnesses (config_fuzzer,h2_huffman_fuzzer,pattern_fuzzer,request_fuzzer,template_fuzzer) target lwan's parsers (config, HTTP/2 Huffman, glob patterns, HTTP requests, templates); the sandboxing code path is not on any harness's reachable graph.Coverage after fix (5 min/harness, libfuzzer + ASan)