client: fix Python 3.14 build (PEP 639 license classifier)#5
Open
jusii wants to merge 2 commits into
Open
Conversation
PEP 639 / recent setuptools rejects the legacy `License :: OSI Approved :: GNU General Public License v3 (GPLv3)` classifier when a SPDX `license = "GPL-3.0-only"` expression is present. This currently breaks `pip install` / `pipx install` of the client on Python 3.14. The SPDX expression already conveys the license, so the classifier is redundant — drop it to unblock the build on modern toolchains.
setuptools writes a `build/` tree into the source dir when building a wheel from source (e.g. via `pip install -e` or `pipx install`). Sibling Python artifacts (`__pycache__/`, `*.egg-info/`) are already ignored — add `build/` to round out the set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install/pipx installof the Python client currently fails on Python 3.14 because recent setuptools enforces PEP 639: a SPDXlicense = "GPL-3.0-only"expression and the legacyLicense :: OSI Approved :: ...classifier cannot coexist. Drop the now-redundant classifier — the SPDX expression already conveys the license.build/to.gitignore. setuptools writes abuild/tree into the source dir when building a wheel from source (e.g.pip install -e client/,pipx install ./client). Sibling artifacts (__pycache__/,*.egg-info/) are already ignored — this rounds out the set.Repro of the original failure
Test plan
pipx install ./clientsucceeds on Python 3.14pip install -e client/still works on older Python (≥3.8 perrequires-python)amigactlconsole script runs (amigactl --help)