Skip to content

Alternative TAP command support#20

Draft
jtlapp wants to merge 4 commits into
tape-testing:mainfrom
jtlapp:tape-options-support
Draft

Alternative TAP command support#20
jtlapp wants to merge 4 commits into
tape-testing:mainfrom
jtlapp:tape-options-support

Conversation

@jtlapp

@jtlapp jtlapp commented Aug 3, 2016

Copy link
Copy Markdown

This is a PR for proposal #19. It contains everything described in that request, plus one thing.

This version of faucet also supports the word "assertions" appearing in place of "tests" in the output summary. The word "tests" is still allowed. See this tape issue for an explanation. I currently have tapeo patching tape to say "assertions" instead (but patching is not stable long-term).

@jtlapp

jtlapp commented Aug 5, 2016

Copy link
Copy Markdown
Author

I've added to this PR a way for faucet to support TAP bail outs without having the support of the old version of tap-parser it relies on. My underlying TAP command can emit bail outs. See #21

@ljharb

ljharb commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator

I don't think there's any value in supporting the word "assertions" when tape and TAP itself both don't.

If that can be removed, and there's still value in the rest of the PR, I'd love to see it rebased so it can be landed.

@ljharb ljharb marked this pull request as draft September 22, 2022 05:22
@ljharb

This comment was marked as resolved.

@jtlapp

jtlapp commented Sep 22, 2022

Copy link
Copy Markdown
Author

I posted this 6 years ago and no longer even remember what this is about. If you're dependent on me to do anything with this, then you might as well close it. I'll be unsubscribing from it.

@ljharb

This comment was marked as resolved.

@ljharb

ljharb commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator

For the record, I only recently took over maintenance of this package, and I apologize that the previous maintainer let it sit ignored for so long.

@ljharb ljharb force-pushed the tape-options-support branch from 8703170 to fa3c290 Compare October 20, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants