chore: make full tracing default, drop -d/-m/-x options, add -s single OP option#115
Open
taodd wants to merge 2 commits into
Open
chore: make full tracing default, drop -d/-m/-x options, add -s single OP option#115taodd wants to merge 2 commits into
taodd wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request streamlines
osdtrace's options and changes the default tracing behavior to better fit user requirements:Summary of Changes
Default Tracing Mode:
OP_FULL_PROBE), which captures all OSD operational latencies and prints detailed per-event row traces.Obsolete Option Removal:
-d <seconds>,-m <avg|max>, and-xoptions completely from command line arguments and getopt parser.handle_avg()) along with its variables and structures to keep the codebase clean.Single Mode Selection:
-soption to allow users to selectively trigger Single OP probe mode (loggingPrimaryLogPG::log_op_statsonly) now that full mode is active by default.Help Banner & Functional Tests:
-hhelp banner and updated all affected functional tests (functional-test-cephadm-rgw.sh,functional-test-embedded-dwarf.sh, andfunctional-test-microceph.sh) to remove the now-obsolete-xoption.