Skip to content

chore: clean up help message and remove probe details section #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taodd merged 1 commit into from
May 27, 2026
Merged

chore: clean up help message and remove probe details section #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/osdtrace.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,8 +1213,8 @@ int parse_args(int argc, char **argv) {
std::cout << " -d <seconds> Set probe duration in seconds to calculate average latency\n";
std::cout << " -m <avg|max> Set operation latency collection mode\n";
std::cout << " -l <milliseconds> Set operation latency threshold to capture\n";
std::cout << " -x Set probe mode to Full OPs. See below for details\n";
std::cout << " -b Set probe mode to Bluestore. See below for details\n";
std::cout << " -x Set probe mode to Full OPs\n";
std::cout << " -b Set probe mode to Bluestore\n";
std::cout << " -j Export DWARF info to JSON file\n";
std::cout << " -i <filename> Import DWARF info from JSON file\n";
std::cout << " -t <seconds> Set execution timeout in seconds\n";
Expand All @@ -1224,16 +1224,6 @@ int parse_args(int argc, char **argv) {
std::cout << " --list List active ceph-osd processes on the host, their PIDs and OSD IDs, and exit\n";
std::cout << " -V, --version Print version information and exit\n";
std::cout << " -h Show this help message\n";
std::cout << "----------------------------------------------------------------------------------------------------------------------------------------\n";
std::cout << " SUPPORTED PROBE MODE DETAILS\n";
std::cout << "----------------------------------------------------------------------------------------------------------------------------------------\n";
std::cout << " Default:\n PrimaryLogPG::log_op_stats\n";
std::cout << " \n Full Ops (-x):\n OSD::dequeue_op\n";
std::cout << " PrimaryLogPG::execute_ctx\n ECBackend::submit_transaction\n OpRequest::mark_flag_point_string\n";
std::cout << " PrimaryLogPG::log_op_stats\n ReplicatedBackend::generate_subop\n ReplicatedBackend::do_repop_reply\n";
std::cout << " BlueStore::queue_transactions\n BlueStore::_txc_calc_cost\n BlueStore::_txc_state_proc\n";
std::cout << " ReplicatedBackend::repop_commit\n OSD::enqueue_op\n";
std::cout << " \n Bluestore (-b):\n BlueStore::log_latency\n";
exit(0);
case ':':
clog << "Missing arg for " << optopt << endl;
Expand Down
Loading