fix: remove attestation conveyance preference check in attestation statement implementations - #55
Open
tanguilp wants to merge 2 commits into
Conversation
This was referenced Apr 6, 2026
|
I ran this against the official test suite and the good news is that there are no regressions from the changes here compared to the current version (0.7). That said, I did run into a few issues which you might run into when you get a chance to run the tests:
[error] #PID<0.2327.0> running WaxFidoTestSuiteServerWeb.Endpoint (connection #PID<0.448.0>, stream id 269) terminated
Server: localhost:4000 (http)
Request: POST /attestation/result
** (exit) an exception was raised:
** (UndefinedFunctionError) function WaxFidoTestSuiteServerWeb.UserKeyCallbackImpl.invalidate_challenge/1 is undefined or private
(wax_fido_test_suite_server 0.1.0)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51