fix: correct archive arch/platform naming in plugin-package.sh#129
Merged
Conversation
Owner
tangcent
commented
Apr 30, 2026
tangcent
commented
- Use x64 instead of amd64 to match actual release asset names
- Remove darwin-amd64 download (no such release exists)
- Map windows -> win32 for local binary naming to match VSCode extension expectations
- Add graceful error handling for failed downloads
|
📦 Build artifact for this PR is available in the GitHub Actions workflow run under Artifacts. |
tangcent
force-pushed
the
fix/plugin-package-download-arch
branch
from
a3b236c to
4ea6b89
Compare
|
📦 Build artifact for this PR is available in the GitHub Actions workflow run under Artifacts. |
tangcent
force-pushed
the
fix/plugin-package-download-arch
branch
from
4ea6b89 to
44e7c55
Compare
|
📦 Build artifact for this PR is available in the GitHub Actions workflow run under Artifacts. |
- Use x64 instead of amd64 to match actual release asset names - Remove darwin-amd64 download (no such release exists) - Map windows -> win32 for local binary naming to match VSCode extension expectations - Add graceful error handling for failed downloads
tangcent
force-pushed
the
fix/plugin-package-download-arch
branch
from
44e7c55 to
b44cdb5
Compare
|
📦 Build artifact for this PR is available in the GitHub Actions workflow run under Artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.