Refactor file locking to use atomic rename pattern to fix NFS stalls - #131
Open
aviezerl wants to merge 3 commits into
Open
Refactor file locking to use atomic rename pattern to fix NFS stalls#131aviezerl wants to merge 3 commits into
aviezerl wants to merge 3 commits into
Conversation
The current locking architecture uses fcntl read-locks ("r") or exclusive
read-locks ("r+") on metadata files (.naryn, .attrs). On NFS, this causes
severe performance degradation and serialization of worker processes during
high-concurrency read operations.
This commit refactors the persistence layer to use an Atomic Rename / Snapshot
pattern, eliminating the need for read locks entirely.
ramijaschek
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current locking architecture uses fcntl read-locks ("r") or exclusive read-locks ("r+") on metadata files (.naryn, .attrs). On NFS, this causes severe performance degradation and serialization of worker processes during high-concurrency read operations.
This commit refactors the persistence layer to use an Atomic Rename / Snapshot pattern, eliminating the need for read locks entirely.