Skip to content

fix: create render pages in background to avoid focus stealing #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangpi26 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: create render pages in background to avoid focus stealing #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b084c
fix: create render pages in background to avoid focus stealing
wangpi26 Jul 9, 2026
f6f7dfa
feat: english comments + stealth injection test
wangpi26 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion browser/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,18 @@ func (p *Pool) Render(ctx context.Context, rawURL string) (RenderResult, error)
return RenderResult{}, err
}

page, err := stealth.Page(b)
// Create the page in the background so headful mode does not pull the Chrome
// window to the foreground and steal focus on every new tab. The only
// difference from stealth.Page is Background:true; the anti-detection script
// is still injected via stealth.JS.
page, err := b.Page(proto.TargetCreateTarget{Background: true})
if err != nil {
return RenderResult{}, fmt.Errorf("new page: %w", err)
}
defer func() { _ = page.Close() }()
if _, err := page.EvalOnNewDocument(stealth.JS); err != nil {
return RenderResult{}, fmt.Errorf("inject stealth: %w", err)
}

page = page.Context(ctx).Timeout(p.opts.RenderTimeout)

Expand Down
39 changes: 39 additions & 0 deletions browser/pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,45 @@ func TestRenderCapturesFinalDOM(t *testing.T) {
}
}

// TestRenderInjectsStealthScript verifies that Render still injects the stealth
// anti-detection script after switching from stealth.Page(b) to a manual
// b.Page(Background:true) + EvalOnNewDocument(stealth.JS). The stealth script
// normalizes navigator.languages to ["en-US","en"] (without it, Chrome reports
// ["en"]), which serves as a reliable indicator that injection succeeded.
func TestRenderInjectsStealthScript(t *testing.T) {
if testing.Short() {
t.Skip("render test drives Chrome; skipped under -short")
}
if _, ok := LookChrome(); !ok {
t.Skip("no Chrome/Chromium found; skipping render test")
}

srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/html; charset=utf-8")
// Page JS writes navigator.languages into the DOM for assertion.
_, _ = w.Write([]byte(`<!doctype html><html><body>
<div id="langs"></div>
<script>document.getElementById("langs").textContent = JSON.stringify(navigator.languages);</script>
</body></html>`))
}))
defer srv.Close()

p := New(Options{Headless: true, Workers: 1, Settle: 300 * time.Millisecond, RenderTimeout: 20 * time.Second})
defer func() { _ = p.Close() }()

ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()

res, err := p.Render(ctx, srv.URL)
if err != nil {
t.Fatalf("render: %v", err)
}
// With stealth injected, navigator.languages is ["en-US","en"]; without it, ["en"].
if !strings.Contains(res.HTML, `["en-US","en"]`) {
t.Errorf("stealth script not injected: navigator.languages should be [\"en-US\",\"en\"], got HTML:\n%s", res.HTML)
}
}

func TestIsHTML(t *testing.T) {
cases := []struct {
ct string
Expand Down