v0.0.344: iter(fn, sentinel) + slice.indices + _CacheInfo#265
Merged
Conversation
Closes F4, F5, and C5 from the v0.1.0 audit. Three small surface fixes that don't share implementation but each is too small for its own release. iter(callable, sentinel) returns an iterator that calls callable until the result equals sentinel. slice.indices(n) normalises the slice against length n, mirroring CPython's PySlice_GetIndices; raises ValueError on step==0. functools.lru_cache.cache_info() now returns a _CacheInfo(hits, misses, maxsize, currsize) namedtuple built via makeNamedTuple; both info.hits and info[0] work, and the class is exposed on the functools module dict for isinstance checks. Spec at notes/Spec/1500/1538_goipy_v0044_iter_slice_cacheinfo.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iter(callable, sentinel)two-arg form (F4): returns iterator that calls callable until result equals sentinel.slice.indices(n)(F5): normalises slice against length, mirrors CPythonPySlice_GetIndices.functools.lru_cache.cache_info()returns a_CacheInfonamedtuple (C5) —info.hits/.misses/.maxsize/.currsizeplus tuple indexing.notes/Spec/1500/1538_goipy_v0044_iter_slice_cacheinfo.md. Fixture:internal/testdata/344_iter_slice_cacheinfo.py.Test plan
go test ./... -timeout 600sgreen