fix: rename profile "Display name" to "Name" and auto-derive name from email (#1941)#2124
Open
larryro wants to merge 2 commits into
Open
fix: rename profile "Display name" to "Name" and auto-derive name from email (#1941)#2124larryro wants to merge 2 commits into
larryro wants to merge 2 commits into
Conversation
Collaborator
Author
Desk Review — #1941 (rename "Display name" → "Name" + auto-derive Name from email)Verdict: ✅ READY TO MERGE. Reviewed the full implementation on CI & tests
What's correct
Non-blocking observations (optional follow-ups, none required for merge)
None of the above blocks merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1941.
What changed
1. Renamed the profile label "Display name" → "Name"
settings.account.profile.name:"Display name"→"Name"(en),"Anzeigename"→"Name"(de),"Nom d'affichage"→"Nom"(fr), and the matchingdescriptionprose.id="display-name"→id="name".2. New shared util
deriveNameFromEmail(email)services/platform/lib/utils/derive-name-from-email.tswith co-located Vitest tests (21 cases). Implements the issue's advanced heuristic: strip+tag, tokenize on. _ -, strip leading/trailing digits per token, Title-Case multi-char tokens, drop single-char initials, keep separator-free handles verbatim (mk→mk), split camelCase (johnDoe→John Doe). Covers numeric-only, empty, unicode, very-long, repeated-separator and trailing-dot edge cases.3. Applied the suggestion + email-before-name ordering
account-step.tsx): added an editable Name field (email → name → password), pre-filled from the email and re-derived until the user edits it; sends the real name instead ofname: email.member-add-dialog.tsx): reordered to email-first, then Name pre-filled from the email (editable).account-form.tsx): reordered to email-first, then Name; pre-fills a derived suggestion when the saved name is empty or equals the email (legacy first-run accounts).Docs & QA guides
Updated
docs/{en,de,fr}/platform/member/preferences.mdand the manual QA guides (settings.md,responsive.md) to the new label/ordering.Verification
bunx tsc --noEmit(platform) — green.vitest --project server --project pii— 73,593 tests pass (incl. the new 21).oxlint --type-awareon changed files — clean.oxfmt --check— clean.