feat(platform): give toasts a concise title and description (#1944)#2123
Open
larryro wants to merge 1 commit into
Open
feat(platform): give toasts a concise title and description (#1944)#2123larryro wants to merge 1 commit into
larryro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves #1944. Splits the shared
toastnamespace copy into concisetitle+descriptionpairs and updates every call site to pass both, establishing the title+description convention for toasts.Changes
messages/{en,de,fr}.json— restructured the entiretoast.success.*/toast.error.*namespace from single-line strings into{ title, description }objects.de-CHinherits fromde(no override needed). Titles are short headlines; descriptions carry the precise follow-up.toastnamespace to pass bothtitleanddescription:automation-row-actions.tsx,account-form.tsx,branding-form.tsx,organization-settings.tsx,member-add-dialog.tsx,configuration.tsx,forced-change-password.$id.tsxuse-convex-mutation.ts— generic error fallback now useserror.generic.title+error.generic.descriptionentity-delete-dialog.tsx/use-delete-dialog.ts— added an optionalsuccessDescriptionso the shared delete dialog renderssuccess.deletedas title + description.claude/skills/react/SKILL.md— documented the title+description convention so new toasts follow it.Verification
bun run --filter @tale/platform test(i18n suite) — green: parity + usage (orphan-key) checks pass for the new nested keys across all locales.bunx tsc --noEmit(platform typecheck) — green.bunx oxlinton changed files — 0 warnings, 0 errors.bunx oxfmt --checkon changed files — clean.Notes
toastnamespace + its call sites. Feature-local toasts that already pass a title (and often a description) are unaffected; the new convention bullet guides future ones.docs/change: this refines existing micro-copy within shipped features rather than adding a documented feature surface.