fix: rename branding "Clear all" action to "Reset" (#1962)

[larryro]

Summary

Renames the branding action label from "Clear all" to "Reset" per #1962.

The shared common.actions.clearAll key is reused by the data-table bulk-actions and filter components (data-table-bulk-actions.tsx, data-table-filters.tsx), so it was not renamed. Instead, the branding form now uses the existing common.actions.reset key (already present as "Reset" / "Zurücksetzen" / "Réinitialiser" in all locales), avoiding any ripple to other usages.

Changes

• services/platform/app/features/settings/branding/components/branding-form.tsx: use tCommon('actions.reset') instead of tCommon('actions.clearAll').

Acceptance criteria

• The branding action reads "Reset".
• No unintended changes to other "Clear all" usages.

Closes #1962

Verification

• bunx vitest --run --config vitest.ui.config.ts branding-form → 9 passed
• bunx oxlint --type-aware on the changed file → 0 warnings, 0 errors

[larryro]

Desk Review — READY TO MERGE ✅

Verdict: READY TO MERGE.

Change

Single-line i18n label swap in services/platform/app/features/settings/branding/components/branding-form.tsx:375:
tCommon('actions.clearAll') → tCommon('actions.reset'). tCommon is bound to the common namespace (useT('common'), line 86), so this resolves to common.actions.reset.

Why this approach is correct

The issue (#1962) warned: if common.actions.clearAll is reused elsewhere, introduce a separate key rather than renaming the shared one. The shared clearAll key is still used by data-table-filters.tsx (×2) and data-table-bulk-actions.tsx (×1), so renaming would have been wrong. The implementer instead reused the pre-existing actions.reset key (already used by date-range-picker.tsx) — cleaner than adding a new key, and semantically apt for a reset-to-default action.

Acceptance criteria

• ✅ Branding action now reads "Reset".
• ✅ No unintended changes to other "Clear all" usages — clearAll untouched in all locales and all 3 consumers.
• ✅ All locales covered: common.actions.reset = Reset (en) / Zurücksetzen (de) / Réinitialiser (fr). de-CH.json is a sparse override and correctly falls back to de.

Verification

• CI: all checks green (Build platform, Type check, Lint, Knip, Unit, all 16 Playwright shards, etc.; only conditional skipping entries for fork-PR image validation / Trivy).
• Tests run locally:
  • bunx vitest --run --config vitest.ui.config.ts branding-form → 9 passed.
  • bunx vitest --run --project server lib/i18n/messages.test.ts (i18n parity + usage, enforce mode) → 23 passed — confirms the referenced key exists across all required locales with no orphaned references.

Non-blocking note

The handler/state names (handleClearBranding, hasAnyBranding) still say "Clear" while the label now says "Reset" — a minor internal vocabulary mismatch only, not user-facing. Not a blocker.

Scope is minimal (1 file, 1 line), no regressions, tests pass, CI green. Approving.