Skip to content

fix: remove search and multi-select from the AI providers table (#1957)#2110

Open
larryro wants to merge 1 commit into
mainfrom
tale/xs7dcrdt4b2f0xb9n3kwe3b66h897gc5
Open

fix: remove search and multi-select from the AI providers table (#1957)#2110
larryro wants to merge 1 commit into
mainfrom
tale/xs7dcrdt4b2f0xb9n3kwe3b66h897gc5

Conversation

@larryro

@larryro larryro commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the search input and the multi-select / bulk-delete affordances from the AI providers table, per #1957.

Changes

  • providers-table.tsx: drop the createSelectColumn checkbox column, the BulkDeleteBar footer, and the row-selection state/handlers; remove the search config from useListPage.
  • use-providers-table-config.tsx: remove the now-unused searchPlaceholder from the config.
  • messages/{en,de,fr}.json: remove the now-unused providers.searchProvider string from all locales.

Acceptance criteria

  • AI providers table has no search.
  • AI providers table has no multi-select / bulk actions.

Verification

  • oxlint --type-aware on the affected feature: clean.
  • vitest run on the providers table/list tests: 7 passed.
  • Full project typecheck deferred to CI (exceeds local memory ceiling).

Closes #1957

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@larryro, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 26 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 28795425-505c-420e-b493-f54838b34275

📥 Commits

Reviewing files that changed from the base of the PR and between 6b90e78 and 599b272.

📒 Files selected for processing (5)
  • services/platform/app/features/settings/providers/components/providers-table.tsx
  • services/platform/app/features/settings/providers/hooks/use-providers-table-config.tsx
  • services/platform/messages/de.json
  • services/platform/messages/en.json
  • services/platform/messages/fr.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tale/xs7dcrdt4b2f0xb9n3kwe3b66h897gc5

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@larryro

larryro commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Desk Review — READY TO MERGE ✅

Scope: Removes search + multi-select/bulk-delete from the AI providers table (#1957). 5 files, +2 / −52.

CI

All 40 checks green (Type check, Lint, Knip, Format, Opengrep, Build platform, Storybook, UI, Browser, and all 16 Playwright platform shards). The single Web container test: skipping is a conditional path-filter skip, not a failure.

Local verification (this review)

  • bunx vitest --run --project client providers-table3 passed
  • bunx vitest --run --project server messages.test (i18n parity/orphan-key) → 34 passed
  • bunx tsc --noEmit (platform, 8 GB heap) → exit 0, clean
  • bunx oxlint --type-aware app/features/settings/providers/0 warnings, 0 errors

Findings (two-round review, 5 dimensions × independent confirmation)

  • Both acceptance criteria met. Search input gone (search config removed from useListPage + searchPlaceholder removed from the config hook + providers.searchProvider key removed from en/de/fr). Multi-select gone (createSelectColumn, BulkDeleteBar footer, rowSelection state, enableRowSelection/onRowSelectionChange, and the bulk handlers all removed).
  • No leftover references to any removed symbol anywhere in the providers feature (grep clean), and the searchProvider key is gone from all locales.
  • getRowId={(row) => row.name} correctly retained — it is load-bearing independent of selection (useListPage would otherwise fall back to a non-existent _id, breaking row keys / new-row animation).
  • No dead code / unused imports left — every remaining import is still used; t in the config hook still drives column headers.
  • Knip-safecreateSelectColumn (14 other consumers) and BulkDeleteBar (18) remain widely used, so removing the providers usages flags nothing.
  • Single-row delete still flows through the same audited useDeleteProvider mutation; no security/boundary regression (pure UI removal, backend untouched).
  • Tests: existing 3 locale-resolution tests remain valid and pass. Absence of a dedicated "no-search/no-multiselect" regression test is acceptable for a pure-affordance removal — the unit harness fully mocks DataTable, so such an assertion belongs in e2e, not here.

Verdict: READY TO MERGE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Remove search + multi-select from the AI providers table

1 participant