Skip to content

fix(sdk): remove non-existent updatedAt from idp.User#1299

Merged
toiroakr merged 1 commit into
mainfrom
fix/remove-idp-user-updated-at
Jun 3, 2026
Merged

fix(sdk): remove non-existent updatedAt from idp.User#1299
toiroakr merged 1 commit into
mainfrom
fix/remove-idp-user-updated-at

Conversation

@k1LoW

@k1LoW k1LoW commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The idp.User interface in packages/sdk/src/runtime/idp.ts declared updatedAt?: string, but the IDP service does not return this field.
  • The declaration was misleading consumers into expecting an optional timestamp that was always undefined at runtime.

Changes

  • Remove updatedAt?: string from the User interface in packages/sdk/src/runtime/idp.ts.

Notes

@changeset-bot

changeset-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c10681f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@tailor-platform/sdk Patch
@tailor-platform/create-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

⚡ pkg.pr.new

@tailor-platform/sdk

pnpm add https://pkg.pr.new/@tailor-platform/sdk@c10681f
pnpm dlx https://pkg.pr.new/@tailor-platform/sdk@c10681f --help

@tailor-platform/create-sdk

pnpm add https://pkg.pr.new/@tailor-platform/create-sdk@c10681f
pnpm dlx https://pkg.pr.new/@tailor-platform/create-sdk@c10681f my-app

commit: c10681f

@k1LoW k1LoW self-assigned this Jun 3, 2026
@k1LoW k1LoW added the bug Something isn't working label Jun 3, 2026
@github-actions

This comment has been minimized.

The IDP service does not return an `updatedAt` field, but the
`idp.User` interface declared `updatedAt?: string`. Consumers were
misled into expecting an optional timestamp that was always
`undefined` at runtime.

Mirrors tailor-platform/function#180, which removed the same field
from `tailor.idp.User` in the function-types package.
@k1LoW
k1LoW force-pushed the fix/remove-idp-user-updated-at branch from f7cfb27 to c10681f Compare June 3, 2026 01:47
@k1LoW k1LoW changed the title fix(runtime): remove non-existent updatedAt from idp.User fix(sdk): remove non-existent updatedAt from idp.User Jun 3, 2026
@k1LoW
k1LoW requested a review from Copilot June 3, 2026 01:50
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Code Metrics Report (packages/sdk)

main (331d82c) #1299 (f56d67e) +/-
Coverage 64.6% 64.6% 0.0%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Details
  |                    | main (331d82c) | #1299 (f56d67e) | +/-  |
  |--------------------|----------------|-----------------|------|
  | Coverage           |          64.6% |           64.6% | 0.0% |
  |   Files            |            381 |             381 |    0 |
  |   Lines            |          13180 |           13180 |    0 |
  |   Covered          |           8517 |            8517 |    0 |
+ | Code to Test Ratio |          1:0.4 |           1:0.4 | +0.0 |
  |   Code             |          87953 |           87952 |   -1 |
  |   Test             |          37763 |           37763 |    0 |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
packages/sdk/src/runtime/idp.ts 100.0% 0.0% modified

SDK Configure Bundle Size

main (331d82c) #1299 (f56d67e) +/-
configure-index-size 18KB 18KB 0KB
dependency-chunks-size 34.47KB 34.47KB 0KB
total-bundle-size 52.47KB 52.47KB 0KB

Runtime Performance

main (331d82c) #1299 (f56d67e) +/-
Generate Median 2,716ms 2,734ms 18ms
Generate Max 2,743ms 2,745ms 2ms
Apply Build Median 2,773ms 2,765ms -8ms
Apply Build Max 2,786ms 2,780ms -6ms

Type Performance (instantiations)

main (331d82c) #1299 (f56d67e) +/-
tailordb-basic 35,147 35,147 0
tailordb-optional 3,841 3,841 0
tailordb-relation 7,428 7,428 0
tailordb-validate 2,566 2,566 0
tailordb-hooks 5,767 5,767 0
tailordb-object 12,136 12,136 0
tailordb-enum 2,462 2,462 0
resolver-basic 9,424 9,424 0
resolver-nested 26,111 26,111 0
resolver-array 18,187 18,187 0
executor-schedule 4,234 4,234 0
executor-webhook 873 873 0
executor-record 8,166 8,166 0
executor-resolver 4,369 4,369 0
executor-operation-function 868 868 0
executor-operation-gql 869 869 0
executor-operation-webhook 888 888 0
executor-operation-workflow 1,714 1,714 0

Reported by octocov

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the SDK’s runtime IDP typing with the actual IDP service response shape by removing a User.updatedAt field that is never returned at runtime, preventing consumers from relying on a consistently-undefined property.

Changes:

  • Removed updatedAt?: string from the exported User interface in packages/sdk/src/runtime/idp.ts.
  • Added a changeset to publish the type correction in the next release.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/sdk/src/runtime/idp.ts Removes the non-existent updatedAt property from the public idp.User type to match runtime behavior.
.changeset/remove-idp-user-updated-at.md Adds release notes / versioning entry for the idp.User type correction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k1LoW
k1LoW marked this pull request as ready for review June 3, 2026 01:53
@k1LoW
k1LoW requested review from remiposo and toiroakr as code owners June 3, 2026 01:53
@claude

claude Bot commented Jun 3, 2026

Copy link
Copy Markdown

📖 Docs Consistency Check

✅ No inconsistencies found between documentation and implementation.

Checked areas:

  • packages/sdk/src/runtime/idp.ts - idp.User interface
  • packages/sdk/docs/services/idp.md - IDP service documentation
  • packages/sdk/docs/runtime.md - Runtime API documentation
  • packages/sdk/docs/testing.md - Test examples
  • example/ directory - Example code patterns

Summary:
The PR removes the updatedAt?: string field from the idp.User interface. The idp.User interface is not explicitly documented in markdown files (it's documented through TypeScript/JSDoc only). All references to updatedAt in the documentation are for TailorDB records (which correctly have both createdAt and updatedAt via db.fields.timestamps()), not IDP users.

Re-run this check by adding the docs-check label to the PR.


@toiroakr toiroakr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toiroakr
toiroakr merged commit b124715 into main Jun 3, 2026
55 checks passed
@toiroakr
toiroakr deleted the fix/remove-idp-user-updated-at branch June 3, 2026 01:58
This was referenced Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants