fix(sdk): remove non-existent updatedAt from idp.User#1299
Conversation
🦋 Changeset detectedLatest commit: c10681f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡ pkg.pr.new@tailor-platform/sdk@tailor-platform/create-sdk
|
This comment has been minimized.
This comment has been minimized.
The IDP service does not return an `updatedAt` field, but the `idp.User` interface declared `updatedAt?: string`. Consumers were misled into expecting an optional timestamp that was always `undefined` at runtime. Mirrors tailor-platform/function#180, which removed the same field from `tailor.idp.User` in the function-types package.
f7cfb27 to
c10681f
Compare
Code Metrics Report (packages/sdk)
Details | | main (331d82c) | #1299 (f56d67e) | +/- |
|--------------------|----------------|-----------------|------|
| Coverage | 64.6% | 64.6% | 0.0% |
| Files | 381 | 381 | 0 |
| Lines | 13180 | 13180 | 0 |
| Covered | 8517 | 8517 | 0 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 87953 | 87952 | -1 |
| Test | 37763 | 37763 | 0 |Code coverage of files in pull request scope (100.0% → 100.0%)
SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
There was a problem hiding this comment.
Pull request overview
This PR aligns the SDK’s runtime IDP typing with the actual IDP service response shape by removing a User.updatedAt field that is never returned at runtime, preventing consumers from relying on a consistently-undefined property.
Changes:
- Removed
updatedAt?: stringfrom the exportedUserinterface inpackages/sdk/src/runtime/idp.ts. - Added a changeset to publish the type correction in the next release.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/sdk/src/runtime/idp.ts | Removes the non-existent updatedAt property from the public idp.User type to match runtime behavior. |
| .changeset/remove-idp-user-updated-at.md | Adds release notes / versioning entry for the idp.User type correction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📖 Docs Consistency Check✅ No inconsistencies found between documentation and implementation. Checked areas:
Summary:
|
Summary
idp.Userinterface inpackages/sdk/src/runtime/idp.tsdeclaredupdatedAt?: string, but the IDP service does not return this field.undefinedat runtime.Changes
updatedAt?: stringfrom theUserinterface inpackages/sdk/src/runtime/idp.ts.Notes
tailor.idp.Userin the function-types package.