improve: Add TailorDB file type definitions#91
Closed
ikawaha wants to merge 1 commit into
Closed
Conversation
| metadata: { | ||
| contentType: string; | ||
| fileSize: number; | ||
| } |
Contributor
There was a problem hiding this comment.
[q]
fileのrecordはあるが、file uploadがまだされていない状態の時にundefiendは返りますか？あるいはdefaultの空文字やfilesize 0が帰りますか？あるいはerror?
| /** | ||
| * File stream iterator for TailorDB file downloads | ||
| */ | ||
| interface TailordbFileStreamIterator { |
Contributor
There was a problem hiding this comment.
AsyncIterableIterator という言語標準の型があるみたいです。value はanyになっていますがUint8Arrayに制約できるであっていますでしょうか？
interface TailordbFileStreamIterator extends AsyncIterableIterator<Uint8Array> {
close(): Promise<void>;
}
| sha256sum: string; | ||
| lastUploadedAt: string; | ||
| }>; | ||
| }; |
Contributor
There was a problem hiding this comment.
こちらもuploadしていない状況でのundefinedなどが返るかどうかが気になります
Contributor
Author
|
Closing this PR to revisit the API interface design. Will reopen or submit a new one after the revision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tailordb file type の TypeScript 定義を追加しました。
見よう見まねで書いているので、ツッコミをお願いします 🙇