corrected find_enum and find_message for keyword identifiers#76
Open
awestlake87 wants to merge 1 commit into
Open
corrected find_enum and find_message for keyword identifiers#76awestlake87 wants to merge 1 commit into
awestlake87 wants to merge 1 commit into
Conversation
Owner
|
First thanks for the PR and sorry for answering this late. Can you please give more context why it is needed. Could you add a broken test for instance? pub fn get_ident(ident: &str) -> String { // `&String` is usually replaced with more generic `&str` which both point to the same data
if !ident.contains('.') {
if RUST_KEYWORDS.contains(&ident) {
format!("{}_pb", ident) // this will create a new `String`, probably without new allocation
}
else {
ident.clone()
}
}
else {
ident.split('.').map(|s| get_ident(s)).collect::<Vec<_>>().join(".") // not pretty but ok!, note that i could remove the `to_string` because I changed the signature to work with `&str`
}
} |
Author
|
Oh, yeah my bad. I made issue #75 when I made the pull request, but i forgot to link it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.