Bump cookstyle from 3.0.0 to 6.3.4

[dependabot-preview]

Bumps cookstyle from 3.0.0 to 6.3.4.

Release notes

Sourced from cookstyle's releases.

Cookstyle 6.0.19

RuboCop 0.80.1 Engine

The RuboCop engine that powers Cookstyle has been updated from 0.75.1 to 0.80.1. This new engine includes hundreds of bug fixes and new features that will allow us to write even more advanced Cookstyle rules in the future. This release also renames many of RuboCop's built-in cops so if you have a complex rubocop.yml file that disables or enables rules, you may see warnings instructing you to update your config.

ChefDeprecation Cops At Warning Level

All ChefDeprecation department cops now alert at Warning level instead of Refactor. This means that these cops will now result in Cookstyle exiting with a -1 exit code, which will cause failures in CI tests. ChefDeprecation cops are important to resolve and we believe this will the use of the latest Chef Infra coding standards.

9 New Cops

ChefDeprecations/DeprecatedWindowsVersionCheck

The ChefDeprecations/DeprecatedWindowsVersionCheck cop detects cookbooks that use the legacy older_than_win_2012_or_8? helper method. Chef Infra Client no longer supports Windows releases before 8 / 2012. Those releases are end of life so this check can be removed from cookbooks.

ChefDeprecations/ChefWindowsPlatformHelper

The ChefDeprecations/ChefWindowsPlatformHelper cop detects cookbooks that use the deprecated helper Chef::Platform.windows? to see if a system is running on Windows instead of using platform?('windows') or the new windows? helper.

ChefDeprecations/LogResourceNotifications

The ChefDeprecations/LogResourceNotifications cop detects notifications in the log resource. Beginning in Chef Infra Client 16, the log resource will no longer trigger an update, so these notifications will never fire. This will create problems for users who concatenate notifications from multiple resources into a single log resource so that those notifications only fire a single time. For example, many resource updates in your cookbook may require a service to restart, but a user may only want to trigger that service to restart once. Chef Infra Client 15.8 and later ships with a notify_group resource specifically for aggregating notifications in this way. This resource should be used instead.

Aggregating Notifications with a log resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :write, 'log[Aggregate notifications using a single log resource]', :immediately
end
log 'Aggregate notifications using a single log resource' do
notifies :restart, 'service[foo]', :delayed
end

Aggregating Notifications with a notify_group resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :run, 'notify_group[Aggregate notifications using a single notify_group resource]', :immediately
end
notify_group 'Aggregate notifications using a single notify_group resource' do
notifies :restart, 'service[foo]', :delayed
end

ChefDeprecations/ResourceWithoutNameOrProvides

... (truncated)

Changelog

Sourced from cookstyle's changelog.

v6.3.4 (2020-04-16)

Merged Pull Requests

• Catch more offenses in ChefModernize/RespondToProvides #605 (tas50)
• Add new ChefModernize/RespondToCompileTime cop #607 (tas50)
• Update to RuboCop 0.82 engine #608 (tas50)
• Add ChefDeprecations/DeprecatedShelloutMethods cop #609 (tas50)
• Add Cookstyle 6.3 notes #610 (tas50)
• Add a few missing shell_out methods #611 (tas50)

v6.2.9 (2020-04-04)

Merged Pull Requests

• Fix a crash and false positive in ChefStyle/NegatingOnlyIf #602 (tas50)
• Improve ChefModernize/WhyRunSupportedTrue to detect a common typo #603 (tas50)
• Improve the LogResourceNotifications to tell when notify_group was introduced #604 (tas50)
• Fix typo in ChefRedundantCode/SensitivePropertyInResource warning #606 (tas50)

v6.2.5 (2020-04-03)

Merged Pull Requests

• Add ChefRedundantCode/UseCreateIfMissing cop #595 (tas50)
• Update RuboCop to 0.81 #596 (tas50)
• Fix syntax on ChefCorrectness/IncorrectLibraryInjection. #598 (ncerny)
• Add Chef version constraints to multiple deprecation cops #600 (tas50)
• Detect code that negates an only_if #537 (tas50)
• Add Cookstyle 6.2 notes #601 (tas50)

v6.1.6 (2020-03-27)

Merged Pull Requests

• Add ChefCorrectness/ConditionalRubyShellout cop #586 (tas50)
• Move WindowsVersionHelper to ChefDeprecations & add autocorrect #587 (tas50)
• Add ChefDeprecations/PowershellCookbookHelpers #588 (tas50)
• Add ChefModernize/NodeRolesInclude rule #589 (tas50)
• Fix chef infra version in PowershellInstallWindowsFeature #591 (tas50)
• Add cops for resource / property descriptions #590 (tas50)
• Add Cookstyle 6.1 release notes #593 (tas50)

v6.0.19 (2020-03-20)

Merged Pull Requests

• Move Cookstyle to the Chef Infra project #538 (tas50)
• Update RuboCop engine to 0.80.1 #479 (tas50)
• Disable the Naming/PredicateName #552 (tas50)
• Update ChefRedundant/UnnecessaryNameProperty to detect attributes #551 (tas50)
• Update DefaultActionFromInitialize to not care about variable order #555 (tas50)
• Enable ChefStyle/UnnecessaryOSCheck #573 (tas50)
• Add autocorrection to ChefCorrectness/DnfPackageAllowDowngrades #571 (tas50)

... (truncated)

Commits

• 643ffaf Bump version to 6.3.4 by Chef Expeditor
• 22e9990 Merge pull request #611 from chef/more_shellout
• ac5881c Add a few missing shell_out methods to comments / tests
• 938288c Bump version to 6.3.3 by Chef Expeditor
• f807b17 Merge pull request #610 from chef/6.3_release
• bee6db1 More syntax highlighting
• d33e684 Update RELEASE_NOTES.md
• 708504a Update RELEASE_NOTES.md
• 1f107b9 Update RELEASE_NOTES.md
• c95700e Add Cookstyle 6.3 notes
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[dependabot-preview]

Superseded by #177.